yanglimingcn merged PR #2610:
URL: https://github.com/apache/brpc/pull/2610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.
wwbmmm commented on PR #2610:
URL: https://github.com/apache/brpc/pull/2610#issuecomment-2144584435
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
yanglimingcn commented on PR #2610:
URL: https://github.com/apache/brpc/pull/2610#issuecomment-2132556055
@wwbmmm 这个PR还有问题吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
wwbmmm commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1590507698
##
src/brpc/span.cpp:
##
@@ -506,6 +509,13 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory even if
yanglimingcn commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1590493865
##
src/brpc/span.cpp:
##
@@ -506,6 +509,13 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory e
wwbmmm commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1590484646
##
src/brpc/span.cpp:
##
@@ -506,6 +509,13 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory even if
yanglimingcn commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1585752728
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory e
yanglimingcn commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1582806405
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory e
wwbmmm commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1582486422
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory even if
yanglimingcn commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1580653847
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory e
yanglimingcn commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1580562181
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory e
chenBright commented on PR #2610:
URL: https://github.com/apache/brpc/pull/2610#issuecomment-2071846974
master分支已经修复了ci的问题，可以更新一下PR。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
wwbmmm commented on code in PR #2610:
URL: https://github.com/apache/brpc/pull/2610#discussion_r1575911958
##
src/brpc/span.cpp:
##
@@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) {
}
SpanDB* SpanDB::Open() {
+// Remove old rpcz directory even if
13 matches
Mail list logo
