wasphin commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-2007066853
https://github.com/protocolbuffers/protobuf/blob/v3.24.0/src/google/protobuf/descriptor.h#L469
确实是 24 版本开始的 `start_number`, 当时改糊涂了
--
This is an automated message from the Apach
ketor commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-2003754254
`#if GOOGLE_PROTOBUF_VERSION < 4025000
for (int tag_number = ext_range->start; tag_number < ext_range->end;
++tag_number)
#else
for (int tag_number = ext_range->start_n
ketor commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-2003527639
请问这个PR使用的protobuf的版本是多少呢？
用prototbuf 3.22.5版本验证，cmake编译会报错：
/home/mengsz/git/other/brpc/src/json2pb/json_to_pb.cpp: In function ‘bool
json2pb::JsonValueToProtoMessage(const butil::r
wasphin merged PR #2546:
URL: https://github.com/apache/brpc/pull/2546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
Superskyyy commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-1992555200
请 merge一下 我这里可以验证是不是ok 谢谢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
wwbmmm commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-1987527067
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
wasphin commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-1976919647
未进行生产环境验证，需谨慎使用。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
wwbmmm commented on PR #2546:
URL: https://github.com/apache/brpc/pull/2546#issuecomment-1963223910
> 还有几个问题需要讨论一下：
>
> 1. 目前编译方式有多种, 有一定维护成本：
>
>* cmake 和 bazel 相对标准, 依赖外部工具;
>* config_brpc.sh 是自定义的用于生成 makefile 的配置脚本, 是否有必要再保留？
> 2. Protobuf 22 Log 迁移 absl 后,
wasphin commented on code in PR #2546:
URL: https://github.com/apache/brpc/pull/2546#discussion_r1501831395
##
CMakeLists.txt:
##
@@ -156,6 +154,50 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
endif()
find_package(Protobuf REQUIRED)
+if(Protobuf_VERSION GREATER_EQUAL 4.22)
+
