Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-05-03 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-2093886654 > > > @yanglimingcn 请问这个PR是意味着可以跨tag使用bthread同步原语了吗？ 使用中是否还有需要在注意的问题呢？ > > > > > > 是的，使用过程中没有什么要注意的，和原来的语义保持一致。 > > 太赞了！ 准备开始使用bthread worker pool的特性了。 有问题可以随时沟通

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-05-03 Thread via GitHub
ketor commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-2093121074 > > @yanglimingcn 请问这个PR是意味着可以跨tag使用bthread同步原语了吗？ 使用中是否还有需要在注意的问题呢？ > > 是的，使用过程中没有什么要注意的，和原来的语义保持一致。 太赞了！ 准备开始使用bthread worker pool的特性了。 -- This is an automated message fro

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-04-28 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-2081780448 > @yanglimingcn 请问这个PR是意味着可以跨tag使用bthread同步原语了吗？ 使用中是否还有需要在注意的问题呢？ 是的，使用过程中没有什么要注意的，和原来的语义保持一致。 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-04-27 Thread via GitHub
ketor commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-2080862340 @yanglimingcn 请问这个PR是意味着可以跨tag使用bthread同步原语了吗？ 使用中是否还有需要在注意的问题呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-03-31 Thread via GitHub
wwbmmm merged PR #2551: URL: https://github.com/apache/brpc/pull/2551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-03-10 Thread via GitHub
wwbmmm commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-1987537343 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-03-07 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-1983124012 @wwbmmm 辛苦有时间review这个PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-03-01 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-1974197342 > @wwbmmm 这个PR有一个点没有处理到 int TaskGroup::interrupt(bthread_t tid, TaskControl* c) 这个函数里面在sleep_id != 0，这部分，因为无法拿到tid原来的执行上下文信息，所以没有办法得到正确的tag分组。你看这块怎么处理合适呢？ 修改了一下，给bthread_interrupt

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-02-28 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-1970341448 @wwbmmm 这个PR有一个点没有处理到 int TaskGroup::interrupt(bthread_t tid, TaskControl* c) 这个函数里面在sleep_id != 0，这部分，因为无法拿到tid原来的执行上下文信息，所以没有办法得到正确的tag分组。你看这块怎么处理合适呢？ -- This is an automated mes

[PR] support bthread primitive cross different worker pools (brpc)

2024-02-28 Thread via GitHub
yanglimingcn opened a new pull request, #2551: URL: https://github.com/apache/brpc/pull/2551 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):