[PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
beesflower opened a new pull request, #2943: URL: https://github.com/apache/brpc/pull/2943 ### What problem does this PR solve? Fixed the issue that when using SelectiveChannel, the header could not be transparently transmitted to the subchannel. Issue Number: Problem Summary:

Re: [PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
beesflower commented on code in PR #2943: URL: https://github.com/apache/brpc/pull/2943#discussion_r2033382344 ## src/brpc/selective_channel.cpp: ## @@ -334,7 +334,11 @@ int Sender::IssueRPC(int64_t start_realtime_us) { sub_cntl->set_request_code(_main_cntl->request_code())

Re: [PR] add headers to sub cntl. (brpc)

2025-04-10 Thread via GitHub
wwbmmm commented on PR #2943: URL: https://github.com/apache/brpc/pull/2943#issuecomment-2785019523 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] add headers to sub cntl. (brpc)

2025-04-08 Thread via GitHub
chenBright merged PR #2943: URL: https://github.com/apache/brpc/pull/2943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [PR] add headers to sub cntl. (brpc)

2025-04-07 Thread via GitHub
chenBright commented on code in PR #2943: URL: https://github.com/apache/brpc/pull/2943#discussion_r2031678375 ## src/brpc/selective_channel.cpp: ## @@ -334,7 +334,11 @@ int Sender::IssueRPC(int64_t start_realtime_us) { sub_cntl->set_request_code(_main_cntl->request_code())