Re: [PR] WIP: Support Protbuf 22 (brpc)

2024-02-25 Thread via GitHub
wasphin commented on PR #2546: URL: https://github.com/apache/brpc/pull/2546#issuecomment-1962955207 还有几个问题需要讨论一下: 1. 目前编译方式有多种, 有一定维护成本: - cmake 和 bazel 相对标准, 依赖外部工具; - config_brpc.sh 是自定义的用于生成 makefile 的配置脚本, 是否有必要再保留? 1. Protobuf 22 Log 迁移 absl 后, 需要自定义 absl 的 LogSink 实现自

[PR] WIP: Support Protbuf 22 (brpc)

2024-02-25 Thread via GitHub
wasphin opened a new pull request, #2546: URL: https://github.com/apache/brpc/pull/2546 ### What problem does this PR solve? Issue Number: close #2537 Problem Summary: compatible with protobuf >= 22 ### What is changed and the side effects? Changed: Side ef