Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-07 Thread via GitHub
Superskyyy commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1985019741 > 这个会有PR吗 两周内我会推pr,我还在验证下这样做会不会在什么场景下有副作用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-07 Thread via GitHub
yanglimingcn commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1984982553 这个会有PR吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-06 Thread via GitHub
Superskyyy commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1982298831 这些性能上的测试结果我会过段时间整理好后推到brpc上游的文档里。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-06 Thread via GitHub
Superskyyy commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1981836072 > 有验证过性能收益吗? 在我们的5MB数据chunk传输场景下性能至少提升了15%,应该主要是copy_to这块加速了,这周我会再测一下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] 支持自定义 IOBuf Block size (brpc)

2024-03-06 Thread via GitHub
chenBright commented on issue #2555: URL: https://github.com/apache/brpc/issues/2555#issuecomment-1980347417 有验证过性能收益吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[I] 支持自定义 IOBuf Block size (brpc)

2024-03-01 Thread via GitHub
Superskyyy opened a new issue, #2555: URL: https://github.com/apache/brpc/issues/2555 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** Block size 现在是一个常量,如果支持动态修改的话会出现什么问题吗?使用场景是在我们的rpc里有一些是大块的5mb数据,其他rpc则是很小的。不应该公用一个blocksize。 **Describe the solution you'd like