Re: [PR] Support SCOPE_EXIT macro (brpc)

2024-05-13 Thread via GitHub
yanglimingcn commented on code in PR #2643: URL: https://github.com/apache/brpc/pull/2643#discussion_r1599287855 ## src/butil/memory/scope_guard.h: ## @@ -83,6 +84,25 @@ ScopeGuard MakeScopeGuard(Callback&& callback) noexcept { return ScopeGuard{ std::forward(callback)};

Oncall report from May 6th to May 12th

2024-05-13 Thread Xiguo Hu
Hi, all During the last week 4 issues were closed, 2 issues were commented on. - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org

Re: [PR] Support SCOPE_EXIT macro (brpc)

2024-05-13 Thread via GitHub
chenBright commented on code in PR #2643: URL: https://github.com/apache/brpc/pull/2643#discussion_r1598446032 ## src/butil/memory/scope_guard.h: ## @@ -83,6 +84,25 @@ ScopeGuard MakeScopeGuard(Callback&& callback) noexcept { return ScopeGuard{ std::forward(callback)}; }

Re: [PR] Support SCOPE_EXIT macro (brpc)

2024-05-13 Thread via GitHub
yanglimingcn commented on code in PR #2643: URL: https://github.com/apache/brpc/pull/2643#discussion_r1598329826 ## src/butil/memory/scope_guard.h: ## @@ -83,6 +84,25 @@ ScopeGuard MakeScopeGuard(Callback&& callback) noexcept { return ScopeGuard{ std::forward(callback)};