Re: [PR] selective_channle支持返回response_attachment (brpc)

2023-07-25 Thread via GitHub
chenBright commented on PR #2329: URL: https://github.com/apache/brpc/pull/2329#issuecomment-1651042014 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] RDMA failure (brpc)

2023-07-25 Thread via GitHub
372046933 commented on issue #2265: URL: https://github.com/apache/brpc/issues/2265#issuecomment-1650999253 这个报错也有点奇怪,`ProtocolType`应该是BAIDU_STD才对 https://github.com/apache/brpc/blob/3bc4366b314b55427a2bcd4819d841e0bd8b6fb4/src/brpc/input_messenger.cpp#L115-L122 ``` E0726 12:28:

Re: [VOTE] Release Apache bRPC 1.6.0

2023-07-25 Thread Wang,Weibing
+ 1 (binding) I have checked: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each brpc repo. [x] All files have license headers if necessary. [x] N

Re: [PR] send response之后,request/response对象析构之前执行一些自定义逻辑 (brpc)

2023-07-25 Thread via GitHub
wwbmmm commented on PR #2328: URL: https://github.com/apache/brpc/pull/2328#issuecomment-1650891350 另外,补充一下单测吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] selective_channle支持返回response_attachment (brpc)

2023-07-25 Thread via GitHub
wwbmmm commented on PR #2329: URL: https://github.com/apache/brpc/pull/2329#issuecomment-1650890652 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] send response之后,request/response对象析构之前执行一些自定义逻辑 (brpc)

2023-07-25 Thread via GitHub
wwbmmm commented on code in PR #2328: URL: https://github.com/apache/brpc/pull/2328#discussion_r1274307736 ## src/brpc/controller.h: ## @@ -567,6 +568,14 @@ friend void policy::ProcessThriftRequest(InputMessageBase*); // -1 means no deadline. int64_t deadline_us() con

[brpc] branch master updated: make bvar_max_dump_multi_dimension_metric_number modifiable (#2322)

2023-07-25 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 3bc4366b make bvar_max_dump_multi_dimension_metric

Re: [PR] make bvar_max_dump_multi_dimension_metric_number modifiable (brpc)

2023-07-25 Thread via GitHub
wwbmmm merged PR #2322: URL: https://github.com/apache/brpc/pull/2322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [PR] remove unnecessary libthriftnb (brpc)

2023-07-25 Thread via GitHub
wwbmmm commented on PR #2325: URL: https://github.com/apache/brpc/pull/2325#issuecomment-1650880328 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix duplicate content type (brpc)

2023-07-25 Thread via GitHub
wwbmmm commented on PR #2319: URL: https://github.com/apache/brpc/pull/2319#issuecomment-1650877344 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] RDMA failure (brpc)

2023-07-25 Thread via GitHub
Tuvie commented on issue #2265: URL: https://github.com/apache/brpc/issues/2265#issuecomment-1650846721 这写用的是内存池里的内存。一开始就注册了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] selective_channle支持返回response_attachment (brpc)

2023-07-25 Thread via GitHub
yockie opened a new pull request, #2329: URL: https://github.com/apache/brpc/pull/2329 ### What problem does this PR solve? 测试发现,channel类型是selective_channel时client收不到server填充的response_attachment。 -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] response返回之后,request/response析构之前执行一些自定义逻辑 (brpc)

2023-07-25 Thread via GitHub
yockie opened a new pull request, #2328: URL: https://github.com/apache/brpc/pull/2328 ### What problem does this PR solve? 1.我们的场景希望将响应时间减少到最小,所以希望将一些类似数据上报的耗时操作(是的,特别耗时)放在response返回之后、request/response析构之前做 2.本pr借鉴了 https://github.com/apache/brpc/pull/1433,看这个pr一直没合入且测试发现有些问题&不太满足我们的