serverglen commented on code in PR #1854:
URL: https://github.com/apache/incubator-brpc/pull/1854#discussion_r945464629
##
src/brpc/server.h:
##
@@ -241,6 +241,10 @@ struct ServerOptions {
// Default: NULL (disabled)
RedisService* redis_service;
+// Optional name
serverglen closed issue #1322: bvar支持多维度统计
URL: https://github.com/apache/incubator-brpc/issues/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
serverglen commented on issue #1322:
URL:
https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1214586232
多维度bvar功能已合入，PR：#1608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
serverglen commented on issue #1322:
URL:
https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1214585530
> > > FailedNamed
> >
> >
> >
问一下，您这边应该使用brpc了吧？如果使用的话，辛苦您能更新下[brpc在贵公司的落地场景](https://github.com/apache/incubator-brpc/issues/1640)吗？
另外：建议您订阅[dev@brpc.apache.
Cool, I will resolve conflicts this week.
Best Regards,
serverglen
Weibing Wang 于2022年8月15日周一 11:38写道：
>
> I have merged this:
> * Implement multi bvar feature:
> https://github.com/apache/incubator-brpc/pull/1608
>
> And this PR need to resolve conflicts @Liu Shuai :
> * implement bvar::WindowE
I have merged this:
* Implement multi bvar feature:
https://github.com/apache/incubator-brpc/pull/1608
And this PR need to resolve conflicts @Liu Shuai :
* implement bvar::WindowEx and bvar::PerSecondEx
https://github.com/apache/incubator-brpc/pull/1603
The next oncaller can focus on these two P
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new e1f7c9bc fix the problem that the first
jamesge closed issue #1714: 使用优雅退出时，cleanup_pthread清理keytable会coredump
URL: https://github.com/apache/incubator-brpc/issues/1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jamesge merged PR #1884:
URL: https://github.com/apache/incubator-brpc/pull/1884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.ap
wwbmmm commented on PR #1806:
URL: https://github.com/apache/incubator-brpc/pull/1806#issuecomment-1214574493
和master近期合入的PR产生了冲突，需要解决一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wwbmmm merged PR #1886:
URL: https://github.com/apache/incubator-brpc/pull/1886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apa
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
from f303256f Merge pull request #1608 from serverglen/feature-mbvar
add d82f8667 Fix typo: /user is /usr (#18
wwbmmm commented on PR #1603:
URL: https://github.com/apache/incubator-brpc/pull/1603#issuecomment-1214572974
@serverglen 这个PR冲突了，需要解决下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
wwbmmm merged PR #1608:
URL: https://github.com/apache/incubator-brpc/pull/1608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apa
This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
from 64957045 update readme to add link to coc (#1564)
new cacbd037 Implement multi bvar feature
new 788d
chenBright commented on PR #1884:
URL: https://github.com/apache/incubator-brpc/pull/1884#issuecomment-1214552962
>
我发现在bthread_keytable_pool_destroy里删除kt之前用`atexit_cancel`取消kt的回调析构函数似乎也可以防止重复析构
先thread_atexit再thread_atexit_cancel，似乎多做了一些无用功，而且直接在开始的时候就不将协程变量对应keytable加入到thread_atexi
chenBright commented on PR #1884:
URL: https://github.com/apache/incubator-brpc/pull/1884#issuecomment-1214551221
> > 另一方面，是否考虑在退出时，stop and join
一些框架的常驻线程（worker线程、timer线程、bvar相关线程）？因为在退出的时候，全局变量或者静态变量析构后，常驻线程有几率访问到这些变量，存在coredump风险。相关issue：#1594
、#1726 、#1634
>
> 这个问题能否新建一个issue单独讨
chenBright opened a new issue, #1889:
URL: https://github.com/apache/incubator-brpc/issues/1889
**Describe the bug (描述bug)**
是否考虑在优雅退出时，stop and join
一些框架的常驻线程（worker线程、timer线程、bvar相关线程）？因为在退出的时候，全局变量或者静态变量析构后，常驻线程有几率访问到这些变量，存在coredump风险。相关issue：https://github.com/apache/incubator-brpc/is
Cool
On Fri, Aug 12, 2022 at 7:34 PM Shuai Liu wrote:
> not find other photo, so...
>
> Best Regards,
> serverglen
>
> Jerry Tan 于2022年8月12日周五 14:39写道：
>
> >
> > Liu Shuai's photo looks fun,
> > haha
> >
> > On 2022/08/12 05:08:40 Jerry Tan wrote:
> > > Here it is.
> > >
> > > https://apachecon
wwbmmm commented on PR #1888:
URL: https://github.com/apache/incubator-brpc/pull/1888#issuecomment-1214539860
> 新增的两个文件之所以后缀名之所以改成了cxx是因为当前的编译脚本会自动对cpp文件编译成 .o
，但是新增的两个文件是无法单独编译的，它们其实是会被选择性地加入到event_dispatcher.cpp中一起编译。自己不能编译。所以改成了编译脚本当前不会自动独立编译的后缀cxx，并且cxx也是一种常用的C++源文件后缀。
可以搞两个cpp文件，
zyearn commented on PR #1888:
URL: https://github.com/apache/incubator-brpc/pull/1888#issuecomment-1214439112
Bazel的编译挂了：
```
[1,115 / 1,457] 11 actions, 2 running
Compiling src/brpc/esp_message.cpp; 1s linux-sandbox
Compiling src/brpc/details/usercode_backup_pool.cpp;
zyearn commented on PR #1884:
URL: https://github.com/apache/incubator-brpc/pull/1884#issuecomment-1214438235
> 另一方面，是否考虑在退出时，stop and join
一些框架的常驻线程（worker线程、timer线程、bvar相关线程）？因为在退出的时候，全局变量或者静态变量析构后，常驻线程有几率访问到这些变量，存在coredump风险。相关issue：#1594
、#1726 、#1634
这个问题能否新建一个issue单独讨论？
--
T
guodongxiaren opened a new pull request, #1888:
URL: https://github.com/apache/incubator-brpc/pull/1888
event_dispatcher.cpp 同时兼容Linux和Mac系统，大量使用了条件编译的宏，这种条件编译的代码占了这个文件的大部分。
导致这个代码文件可读性比较差，另外后续如果扩充其他操作系统、其他事件驱动的API，则event_dispatcher可维护性也比较差。
参考Redis中事件驱动库Ae的源码组织形式：
```c
#ifdef
23 matches
Mail list logo
