Re: meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Wang,Weibing
Thanks JB for the suggestion! We will try. Best Regards Weibing On Fri, Aug 5, 2022 at 1:26 PM Jean-Baptiste Onofré wrote: > > Thanks for sharing. > > I agree with the suggestions. I would also add a third one: do kind of > promotion action (blog post, etc), it will attract more users and > deve

Re: meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Jean-Baptiste Onofré
Thanks for sharing. I agree with the suggestions. I would also add a third one: do kind of promotion action (blog post, etc), it will attract more users and developers, and so grow the community. Regards JB On Thu, Aug 4, 2022 at 4:42 PM Jerry Tan wrote: > > Hi, guys, > > we have dinner with ou

Re: meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Wang,Weibing
Nice meeting, thanks to Zhongyi and Pan Juan! I will try to find some commiter candidates from the contributor list. Best Regards, Weibing 在 2022/8/5 上午10:45,“Hu go” 写入: Very glad to have dinner with Jerry, PanJuan and other brpc partners! Let's make brpc better and better. Be

[GitHub] [incubator-brpc] cdjingit commented on issue #1870: 使用example中的例子验证熔断功能(可选熔断和连接超时熔断)

2022-08-04 Thread GitBox
cdjingit commented on issue #1870: URL: https://github.com/apache/incubator-brpc/issues/1870#issuecomment-1206011245 测试的qps多少?加大qps看看?理论上应该能触发,后续我看看能不能在我环境复现一下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-brpc] cdjingit commented on issue #1874: 熔断无法恢复,错误码为112

2022-08-04 Thread GitBox
cdjingit commented on issue #1874: URL: https://github.com/apache/incubator-brpc/issues/1874#issuecomment-1206007679 这里有相似的issue 可以参考 https://github.com/apache/incubator-brpc/issues/1773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Hu go
Very glad to have dinner with Jerry, PanJuan and other brpc partners! Let's make brpc better and better. Best Regards, Xiguo On Fri, Aug 5, 2022 at 10:00 AM Shuai Liu wrote: > A nice dinner meeting, Thanks Tan Zhongyi and PanJuan. > > Best Regards, > serverglen > > Jerry Tan 于2022年8月4日周四 22:42

Re: [incubator-brpc] 01/01: Update README.md

2022-08-04 Thread Hu go
Good, I will sync it to the brpc official website soon. On Thu, Aug 4, 2022 at 8:19 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > jerrytan pushed a commit to branch tanzhongyi003-patch-1 > in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git

[GitHub] [incubator-brpc] FailedNamed commented on issue #1322: bvar支持多维度统计

2022-08-04 Thread GitBox
FailedNamed commented on issue #1322: URL: https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1205965737 > > FailedNamed > > 问一下,您这边应该使用brpc了吧?如果使用的话,辛苦您能更新下[brpc在贵公司的落地场景](https://github.com/apache/incubator-brpc/issues/1640)吗? 另外:建议您订阅[dev@brpc.apache.org](mailto:d

[GitHub] [incubator-brpc] serverglen commented on issue #1322: bvar支持多维度统计

2022-08-04 Thread GitBox
serverglen commented on issue #1322: URL: https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1205961815 > FailedNamed 问一下,您这边应该使用brpc了吧?如果使用的话,辛苦您能更新下[brpc在贵公司的落地场景](https://github.com/apache/incubator-brpc/issues/1640)吗? 另外:建议您订阅dev@brpc.apache.org邮件组,我们会通过邮件沟通和讨论

[GitHub] [incubator-brpc] FailedNamed commented on issue #1322: bvar支持多维度统计

2022-08-04 Thread GitBox
FailedNamed commented on issue #1322: URL: https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1205959483 > 实在不好意思,这部分代码在社区有点分歧,我们尽快同步意见,合入之后通知你。 感谢大佬回复,因为目前最近我们正好想用这个功能做一些业务指标上报,但是prometheus貌似没有cpp sdk之类的(在他们官网和git都没找着),假如我们自己把这部分代码拉下来merge到我们代码里,应该也是可行的吧[思考] -- This is

[GitHub] [incubator-brpc] serverglen commented on issue #1322: bvar支持多维度统计

2022-08-04 Thread GitBox
serverglen commented on issue #1322: URL: https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1205956872 实在不好意思,这部分代码在社区有点分歧,我们尽快同步意见,合入之后通知你。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Shuai Liu
A nice dinner meeting, Thanks Tan Zhongyi and PanJuan. Best Regards, serverglen Jerry Tan 于2022年8月4日周四 22:42写道: > > Hi, guys, > > we have dinner with our mentor Panjuan tonight, > the attendee includes Wang Weibing, Liu Shuai, Hu Xiguo, Wang Xiaofeng, Li > Lei, Tan zhongyi and PanJuan. > > PanJu

meeting minutes for today‘s dinner meeting with Panjuan

2022-08-04 Thread Jerry Tan
Hi, guys, we have dinner with our mentor Panjuan tonight, the attendee includes Wang Weibing, Liu Shuai, Hu Xiguo, Wang Xiaofeng, Li Lei, Tan zhongyi and PanJuan. PanJuan gave us two pieces of advice: 1. post more mail to the dev mail list 2. attract more committer. Great suggestions. we will

[GitHub] [incubator-brpc] FailedNamed commented on issue #1322: bvar支持多维度统计

2022-08-04 Thread GitBox
FailedNamed commented on issue #1322: URL: https://github.com/apache/incubator-brpc/issues/1322#issuecomment-1205227247 你好,我想请问下,为啥到现在这份代码还没被merge,是有其他问题或者其他考虑嘛,都9个月了诶 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-brpc] iamwuyunfeng opened a new issue, #1875: brpc stream 存在接收端已断开连接但发送端完全未感知的可能

2022-08-04 Thread GitBox
iamwuyunfeng opened a new issue, #1875: URL: https://github.com/apache/incubator-brpc/issues/1875 **Describe the bug (描述bug)** 假设发送端和接收端的 max_body_size 都是 64M(FLAGS_max_body_size 默认值),发送端通过 stream 发送一个 128M 的消息可以成功,但是接收端接受会失败,并且接收端的 stream 会被 close,而发送端此时会无法发现 stream 已经 close 了,具体表现为:

[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-04 Thread GitBox
cdjingit commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r937613829 ## src/bvar/mvariable.cpp: ## @@ -0,0 +1,253 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-04 Thread GitBox
cdjingit commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r937577620 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [incubator-brpc] cdjingit commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-04 Thread GitBox
cdjingit commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r937577273 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements