[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

2022-01-23 Thread GitBox
wwbmmm commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790474434 ## File path: src/brpc/redis.h ## @@ -107,21 +107,21 @@ class RedisRequest : public ::google::protobuf::Message { bool SerializeTo(butil::IOBuf

[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1682: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

2022-01-23 Thread GitBox
wwbmmm commented on a change in pull request #1682: URL: https://github.com/apache/incubator-brpc/pull/1682#discussion_r790430360 ## File path: src/brpc/policy/baidu_rpc_protocol.cpp ## @@ -69,7 +69,7 @@ inline void PackRpcHeader(char* rpc_header, int meta_size, int payload_si

[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

2022-01-23 Thread GitBox
x2c3z4 commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790422706 ## File path: src/bthread/mutex.h ## @@ -48,15 +48,15 @@ class Mutex { Mutex() { int ec = bthread_mutex_init(&_mutex, NULL);

[GitHub] [incubator-brpc] yangzhg opened a new pull request #1682: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

2022-01-23 Thread GitBox
yangzhg opened a new pull request #1682: URL: https://github.com/apache/incubator-brpc/pull/1682 Fix build warning, protobuf ByteSize() is deprecated, use ByteSizeLong() instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

2022-01-23 Thread GitBox
x2c3z4 commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790420377 ## File path: src/brpc/redis.h ## @@ -107,21 +107,21 @@ class RedisRequest : public ::google::protobuf::Message { bool SerializeTo(butil::IOBuf

[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1667: Add two cmake option for build

2022-01-23 Thread GitBox
x2c3z4 commented on a change in pull request #1667: URL: https://github.com/apache/incubator-brpc/pull/1667#discussion_r790419591 ## File path: CMakeLists.txt ## @@ -25,6 +25,8 @@ option(WITH_DEBUG_SYMBOLS "With debug symbols" ON) option(WITH_THRIFT "With thrift framed protoco

[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1667: Add two cmake option for build

2022-01-23 Thread GitBox
x2c3z4 commented on a change in pull request #1667: URL: https://github.com/apache/incubator-brpc/pull/1667#discussion_r790419080 ## File path: CMakeLists.txt ## @@ -25,6 +25,8 @@ option(WITH_DEBUG_SYMBOLS "With debug symbols" ON) option(WITH_THRIFT "With thrift framed protoco

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1680: fix(input_messenger) client side retry policy

2022-01-23 Thread GitBox
wwbmmm commented on pull request #1680: URL: https://github.com/apache/incubator-brpc/pull/1680#issuecomment-1019706149 @ehds Thanks for you contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-brpc] wwbmmm commented on issue #1659: go grpc 循环访问 brpc的一个接口服务拿数据,拿到的数据到达一定量的时候,brpc服务端会卡住,客户端收不到回的数据包

2022-01-23 Thread GitBox
wwbmmm commented on issue #1659: URL: https://github.com/apache/incubator-brpc/issues/1659#issuecomment-1019699861 有没有具体的复现方法? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-brpc] wwbmmm commented on issue #1681: ResourcePool一直分配内存,但是不释放,可能在经历峰值流量之后,始终占用大量内存

2022-01-23 Thread GitBox
wwbmmm commented on issue #1681: URL: https://github.com/apache/incubator-brpc/issues/1681#issuecomment-1019697298 目前没有释放空闲ResourcePool的机制 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[incubator-brpc] branch master updated: Update oncall.md

2022-01-23 Thread jerrytan
This is an automated email from the ASF dual-hosted git repository. jerrytan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 2c98d0a Update oncall.md 2c98d0a is d

[GitHub] [incubator-brpc] wwbmmm removed a comment on pull request #1653: Fix unstable bthread_unittest.cpp case

2022-01-23 Thread GitBox
wwbmmm removed a comment on pull request #1653: URL: https://github.com/apache/incubator-brpc/pull/1653#issuecomment-1019691462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1653: Fix unstable bthread_unittest.cpp case

2022-01-23 Thread GitBox
wwbmmm commented on pull request #1653: URL: https://github.com/apache/incubator-brpc/pull/1653#issuecomment-1019694154 这个PR是尝试解决UT失败问题,但看起来并没有解决,先不用合入哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1653: Fix unstable bthread_unittest.cpp case

2022-01-23 Thread GitBox
wwbmmm commented on pull request #1653: URL: https://github.com/apache/incubator-brpc/pull/1653#issuecomment-1019691746 这个PR是尝试解决UT失败问题,但看起来并没有解决,先不用合入哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1653: Fix unstable bthread_unittest.cpp case

2022-01-23 Thread GitBox
wwbmmm commented on pull request #1653: URL: https://github.com/apache/incubator-brpc/pull/1653#issuecomment-1019691419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1667: Add two cmake option for build

2022-01-23 Thread GitBox
wwbmmm commented on a change in pull request #1667: URL: https://github.com/apache/incubator-brpc/pull/1667#discussion_r790396992 ## File path: CMakeLists.txt ## @@ -25,6 +25,8 @@ option(WITH_DEBUG_SYMBOLS "With debug symbols" ON) option(WITH_THRIFT "With thrift framed protoco

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1669: Fix C++ compile issue and clang compile issue

2022-01-23 Thread GitBox
wwbmmm commented on pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#issuecomment-1019686856 This branch has conflicts with master now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

2022-01-23 Thread GitBox
wwbmmm commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790395641 ## File path: src/brpc/redis.h ## @@ -107,21 +107,21 @@ class RedisRequest : public ::google::protobuf::Message { bool SerializeTo(butil::IOBuf

[GitHub] [incubator-brpc] kenshinxf commented on issue #1652: 1.0.0 庆祝发版并感谢贡献者活动

2022-01-23 Thread GitBox
kenshinxf commented on issue #1652: URL: https://github.com/apache/incubator-brpc/issues/1652#issuecomment-1019661628 github id: kenshinxf brpc 贡献url:https://github.com/apache/incubator-brpc/pull/98/commits -- This is an automated message from the Apache Git Service. To respond to the

Oncall report from Jan 10th to Jan 23rd

2022-01-23 Thread Lorin Lee
Hi all, last 2 weeks 3 issues are closed, 2 PRs are merged. Regards, LorinLee - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org

[GitHub] [incubator-brpc] ethanvc opened a new issue #1681: ResourcePool一直分配内存,但是不释放,可能在经历峰值流量之后,始终占用大量内存

2022-01-23 Thread GitBox
ethanvc opened a new issue #1681: URL: https://github.com/apache/incubator-brpc/issues/1681 **Describe the bug (描述bug)** ResourcePool只分配,但是从不将内存归还给操作系统。 而IDC机器一般会关闭分页文件,会导致闲时内存占用也非常高。无法腾出资源进行其它操作。 或者可能是我没看到释放的时机。如果有,整个释放操作时在哪里?多谢。 -- This is an automated messa