[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270436885 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270436885 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270414806 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] zyearn opened a new issue #709: 下游全部熔断后恢复机制

2019-03-29 Thread GitBox
zyearn opened a new issue #709: 下游全部熔断后恢复机制 URL: https://github.com/apache/incubator-brpc/issues/709 一台机器暂时卡死或因某些原因返回错误数过多目前会被熔断器从serverlist中摘除,如果被熔断的机器太多,那么剩下的机器就会负载变大,错误变多,从而更加容易发生熔断,一种极端的case是所有机器都发生了熔断。此时,如果一台机器恢复了,大量的请求蜂拥而至,从而使得该台机器再次熔断,集群永远无法恢复到正常状态。有一种解决办法是服务端设置正确的并发数,对于因超过容量而错误的请求,熔

[GitHub] [incubator-brpc] tiankonguse commented on issue #649: 支持热点情况下的一致性hash?

2019-03-29 Thread GitBox
tiankonguse commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-477950527 @GardianT 了解你的意思了。 重新描述你的问题:会有某一个key突然特别热(新闻热点),这个量可能足够大到 一致性HASH对应的节点支撑不住。 这种使用小SET不好,比较浪费资源,扩容难度也较大。 可以按照第二种设计:一致性HASH下面的节点是路由表,路由表下有若干机器

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270331376 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright (c) 2

Re: the tasklist that needed for the first apache release

2019-03-29 Thread James Ge
ok, I'll take task 5 On Fri, Mar 29, 2019 at 4:07 PM tan zhongyi wrote: > Great,thanks huwenwei. > > Now Let me to clarify the task of our first release > > 1. Get all dependency third party’s copyright and apppend them to brpc > License file > @ Zhangyi Chen > > 2. Add Notice and Disclaimer f

[GitHub] [incubator-brpc] jamesge edited a comment on issue #697: 客户端出现大量timeout

2019-03-29 Thread GitBox
jamesge edited a comment on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-477922530 fork两次目前不支持,见 #208 ,现象就是很多bvar都为0或不再更新 This is an automated message from the Apache Git Ser

[GitHub] [incubator-brpc] jamesge commented on issue #697: 客户端出现大量timeout

2019-03-29 Thread GitBox
jamesge commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-477922530 fork两次目前不支持,见 #208 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout

2019-03-29 Thread GitBox
cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-477921855 目前bvar问题已经定位到原因: 由于我们的程序是使用守护进程方式启动,会fork两次. 改为使用非守护进程运行(前台运行),bvar系统以及统计项是没有问题的. 请问守护进程模式,会有什么限制吗? ---

Re: the tasklist that needed for the first apache release

2019-03-29 Thread tan zhongyi
Great,thanks huwenwei. Now Let me to clarify the task of our first release 1. Get all dependency third party’s copyright and apppend them to brpc License file @ Zhangyi Chen 2. Add Notice and Disclaimer file to mention its copyright belong to apache foundation @tanzhongyi 3. Make a shor

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-477891154 1)将查询接口改成原来的方式,2)修改了批量操作的返回结果逻辑,默认replies默认为10,数量可动态变化。 ---