Re: Replication Worker and targetBookie.

2018-03-09 Thread Ivan Kelly
> The "predicate" approach is problematic, it can potentially cause some > ledgers never being replicated. Ideally, this is something should be done > by auditor, because auditor > knows the ledgers, the alive bookies and the network topology, auditor > should be able to compute a replication plan

Re: Replication Worker and targetBookie.

2018-03-09 Thread Sijie Guo
On Thu, Mar 8, 2018 at 11:46 AM, Venkateswara Rao Jujjuri wrote: > On Thu, Mar 8, 2018 at 11:33 AM, Sijie Guo wrote: > > > On Thu, Mar 8, 2018 at 8:07 AM, Venkateswara Rao Jujjuri < > > jujj...@gmail.com> > > wrote: > > > > > On Thu, Mar 8, 2018 at 2:38 AM, Ivan Kelly wrote: > > > > > > > > Giv

Re: Replication Worker and targetBookie.

2018-03-08 Thread Venkateswara Rao Jujjuri
On Thu, Mar 8, 2018 at 11:33 AM, Sijie Guo wrote: > On Thu, Mar 8, 2018 at 8:07 AM, Venkateswara Rao Jujjuri < > jujj...@gmail.com> > wrote: > > > On Thu, Mar 8, 2018 at 2:38 AM, Ivan Kelly wrote: > > > > > > Given that RackAwareEnsemble policy defaults to finding a replacement > > > > bookie wi

Re: Replication Worker and targetBookie.

2018-03-08 Thread Sijie Guo
On Thu, Mar 8, 2018 at 8:07 AM, Venkateswara Rao Jujjuri wrote: > On Thu, Mar 8, 2018 at 2:38 AM, Ivan Kelly wrote: > > > > Given that RackAwareEnsemble policy defaults to finding a replacement > > > bookie within > > > the same rack, when a bookie is lost in a rack, the entire cluster will > >

Re: Replication Worker and targetBookie.

2018-03-08 Thread Venkateswara Rao Jujjuri
On Thu, Mar 8, 2018 at 2:38 AM, Ivan Kelly wrote: > > Given that RackAwareEnsemble policy defaults to finding a replacement > > bookie within > > the same rack, when a bookie is lost in a rack, the entire cluster will > be > > replicating > > to the same 'rack'. This puts a lot of pressure on the

Re: Replication Worker and targetBookie.

2018-03-08 Thread Ivan Kelly
> Given that RackAwareEnsemble policy defaults to finding a replacement > bookie within > the same rack, when a bookie is lost in a rack, the entire cluster will be > replicating > to the same 'rack'. This puts a lot of pressure on the rack and also takes > a longer time > to bring up the replicati

Replication Worker and targetBookie.

2018-03-07 Thread Venkateswara Rao Jujjuri
With the fixes to ISSUE #596 ISSUE #583(6fcabfc80c5bd6cdfa9252cdfc4ed209cc0620a6) which allowed auto replication should honor ensemble placement policy, this patch also removed `targetBookie` from ReplicationWorker which means any node can replicate 'to' any other node in the cluster. This is grea