Re: git/github commit hooks

2017-10-11 Thread Enrico Olivelli
2017-10-11 18:58 GMT+02:00 Ivan Kelly : > Responses inline. > > >> Last thursday, we a had a short discussion about possibly changing the > >> merge process to allow unsquashed commits > >> > > > > I don't think is the best way. > > The history of a pull request may have several minor commits and

Re: git/github commit hooks

2017-10-11 Thread Ivan Kelly
Responses inline. >> Last thursday, we a had a short discussion about possibly changing the >> merge process to allow unsquashed commits >> > > I don't think is the best way. > The history of a pull request may have several minor commits and IMO it is > better to hide such conversation in the offi

Re: git/github commit hooks

2017-10-11 Thread Enrico Olivelli
Sam, I agree we have to make some clean up and add some more rule. My comments inline Thank you Enrico 2017-10-10 0:01 GMT+02:00 Sam Just : > Last thursday, we a had a short discussion about possibly changing the > merge process to allow unsquashed commits > I don't think is the best way. The h