Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-09-05 Thread Yan Zhao
There is a new finding about it. https://github.com/apache/bookkeeper/pull/2805 also introduces deadlock in ZkLedgerUnderreplicationManager. ## ReplicationWorker mechanism The working mechanism of ReplicationWorker is as follows: it retrieves an under-replicated ledger, transfers the data of t

Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-08-22 Thread Yan Zhao
> Overall looks good to me. > > Only one thing I want to mention, should we use a new way to fix it, > not only remove the original method? > Because the issue indeed exists, and we need to fix it. > > Thanks, > Yong Yes, I would like to use a scheduled task to trigger it.

Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-08-21 Thread Yong Zhang
Overall looks good to me. Only one thing I want to mention, should we use a new way to fix it, not only remove the original method? Because the issue indeed exists, and we need to fix it. Thanks, Yong On Mon, 21 Aug 2023 at 09:37, Hang Chen wrote: > +1 > > The interface introduces a heavy load

Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-08-20 Thread Hang Chen
+1 The interface introduces a heavy load on Zookeeper, and we need to remove it. For branch-4.15 and branch-4.16, we can keep the interface and remove the implementation and remove the interface on the master branch. Thanks, Hang Enrico Olivelli 于2023年8月20日周日 21:24写道: > > +1 > > Enrico > > Il G

Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-08-20 Thread Enrico Olivelli
+1 Enrico Il Gio 17 Ago 2023, 10:06 horizonzy ha scritto: > In https://github.com/apache/bookkeeper/pull/2805, it introduces > UnderReplicatedLedgersChangedCb to watch the zookeeper `underreplication` > path. After a `underreplication` ledger mark is replicated, the > UnderReplicatedLedgersChan