Re: Minor fix on gitHub actions build

2020-05-08 Thread Yong Zhang
Sorry about that. I misunderstood. On Fri, 8 May 2020 at 20:37, Enrico Olivelli - Diennea wrote: > Thank you Yong > But I am not sure what's your LGTM for > > My question is: > I wonder if for this kind of small patches that do not have an impact > over code it is possible to simply commit t

Re: Minor fix on gitHub actions build

2020-05-08 Thread Enrico Olivelli - Diennea
Thank you Yong But I am not sure what's your LGTM for My question is: I wonder if for this kind of small patches that do not have an impact over code it is possible to simply commit them just given another +1 from a non-committer, but "known contributor". Enrico Il giorno 08/05/20, 14:3

Re: Minor fix on gitHub actions build

2020-05-08 Thread Yong Zhang
LGTM. Yong On Fri, 8 May 2020 at 20:26, Enrico Olivelli wrote: > Thoughts ? > > Enrico > > Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli < > eolive...@gmail.com> > ha scritto: > > > Hello Bookkeepers, > > I would like to commit this little patch that improves GitHub Actions. > > > > h

Re: Minor fix on gitHub actions build

2020-05-08 Thread Enrico Olivelli
Thoughts ? Enrico Il giorno mar 5 mag 2020 alle ore 14:49 Enrico Olivelli ha scritto: > Hello Bookkeepers, > I would like to commit this little patch that improves GitHub Actions. > > https://github.com/apache/bookkeeper/pull/2323 > > I am looking for a +1. > > Matteo Minardi already approved i

Minor fix on gitHub actions build

2020-05-05 Thread Enrico Olivelli
Hello Bookkeepers, I would like to commit this little patch that improves GitHub Actions. https://github.com/apache/bookkeeper/pull/2323 I am looking for a +1. Matteo Minardi already approved it. I wonder if for this kind of small patches that do not have an impact over code it is possible to si