On Wed, May 3, 2017 at 4:16 AM, Charan Reddy G
wrote:
>
> "The question is - is this really an issue? When roll over happen, it
> might cause an entry log file won't be garbage collected or compacted in
> this lifecycle of the bookie. But it doesn't actually impact correctness,
> right?"
>
> Yes
"The question is - is this really an issue? When roll over happen, it might
cause an entry log file won't be garbage collected or compacted in this
lifecycle of the bookie. But it doesn't actually impact correctness, right?"
Yes it is not correctness issue. But the chances of those entrylogs getti
Il ven 28 apr 2017, 09:05 Sijie Guo ha scritto:
> Hi Enrico,
>
> Let's try to figure things out in the email thread before create a JIRA.
>
Got it, sorry
Enrico
>
> - Sijie
>
> On Thu, Apr 27, 2017 at 11:43 PM, Enrico Olivelli
> wrote:
>
>> Thank you Charan,
>> Can you create a JIRA?
>> Do you
Hi Enrico,
Let's try to figure things out in the email thread before create a JIRA.
- Sijie
On Thu, Apr 27, 2017 at 11:43 PM, Enrico Olivelli
wrote:
> Thank you Charan,
> Can you create a JIRA?
> Do you already have a fix?
>
> Il ven 28 apr 2017, 00:27 Charan Reddy G ha
> scritto:
>
>> Hey,
>
I think Bookkeeper-833 is irrelevant, no? Even it is Long.MAX, it would
still have the roll over problem.
The question is - is this really an issue? When roll over happen, it might
cause an entry log file won't be garbage collected or compacted in this
lifecycle of the bookie. But it doesn't actua
Thank you Charan,
Can you create a JIRA?
Do you already have a fix?
Il ven 28 apr 2017, 00:27 Charan Reddy G ha
scritto:
> Hey,
>
> With Bookkeeper-833 Bug (
>
> https://github.com/apache/bookkeeper/commit/da1a2fa6b19ddcdba68834147bf6afbe5bf90cbf
> ),
> entryLogId in EntryLogger is capped at Int
Hey,
With Bookkeeper-833 Bug (
https://github.com/apache/bookkeeper/commit/da1a2fa6b19ddcdba68834147bf6afbe5bf90cbf),
entryLogId in EntryLogger is capped at Int.MAX, so preallocatedLogId rolls
over to 0 after reaching Int.MAX. In EntryLogger.flushRotatedLogs we set
"leastUnflushedLogId = flushedLo
