+1 LGTM.
THanks,
CHaran
On Tue, Jul 18, 2017 at 10:43 AM, Sijie Guo wrote:
> Charan,
>
> Here is the pull request to address the problem: https://github.com/
> apache/bookkeeper/pull/257
>
> - Sijie
>
> On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo wrote:
>
>> Sure.
>>
>> I was looking into that
Charan,
Here is the pull request to address the problem:
https://github.com/apache/bookkeeper/pull/257
- Sijie
On Wed, Jul 19, 2017 at 12:49 AM, Sijie Guo wrote:
> Sure.
>
> I was looking into that last night as well. I will work on that.
>
> - Sijie
>
> On Tue, Jul 18, 2017 at 4:23 PM, Charan
Sure.
I was looking into that last night as well. I will work on that.
- Sijie
On Tue, Jul 18, 2017 at 4:23 PM, Charan Reddy G
wrote:
> Hey Sijie,
>
> It looks like one of your commit -https://github.com/
> reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2
> broke BookieIn
Hey Sijie,
It looks like one of your commit -
https://github.com/reddycharan/bookkeeper/commit/c49621bacaa960d240afbbee83a9703b4cbc3ec2
broke BookieInitializationTest.
testWithDiskFullAndAbilityToCreateNewIndexFile testcase. Can you please
check that.
Thanks,
Charan
