Awesome! Glad to see the community coordinate the efforts working on this.
Sijie
On Jul 5, 2017 5:48 AM, "Enrico Olivelli" wrote:
> David,,
> I see you have created an issue for the first part of bookkeeper-server.
> Maybe you can also create issues for every package, this way anyone can
> star
Il mar 4 lug 2017, 18:06 Dávid Szigecsán ha scritto:
> Hi,
>
> Yes, I created a PR for the first part of the change. (All modules except
> bookkeeper-server)
> I started to do the second part (bookkeeper-server), but It is a huge
> change. It contains almost 5000 issues.
> I'm thinking about how
Hi,
Yes, I created a PR for the first part of the change. (All modules except
bookkeeper-server)
I started to do the second part (bookkeeper-server), but It is a huge
change. It contains almost 5000 issues.
I'm thinking about how to slice it up to small steps.
2017-07-04 17:06 GMT+02:00 Sijie Guo
+1 for current PR not including bookkeeper-server, And as Enrico suggested,
may be we could do bookkeeper-server changes at the end of 4.5.0 or
beginning of 4.6.0.
On Tue, Jul 4, 2017 at 11:06 PM, Sijie Guo wrote:
> Those modules are fine, they are rarely touched any way.
>
> On Jul 4, 2017 8:57
Those modules are fine, they are rarely touched any way.
On Jul 4, 2017 8:57 AM, "Enrico Olivelli" wrote:
> 2017-07-04 16:50 GMT+02:00 Sijie Guo :
> > It is fine to me if we do modules by modules and packages by packages in
> > bookkeeper-server. We can keep the changes smaller for reviews and e
2017-07-04 16:50 GMT+02:00 Sijie Guo :
> It is fine to me if we do modules by modules and packages by packages in
> bookkeeper-server. We can keep the changes smaller for reviews and easier
> to merge.
I see in the issue and PR
https://github.com/apache/bookkeeper/pull/231 that he is adding CS to
It is fine to me if we do modules by modules and packages by packages in
bookkeeper-server. We can keep the changes smaller for reviews and easier
to merge.
Also, it might be good to also discuss on the issue to keep David updated
if he is not in the dev@ list.
Sijie
On Jul 4, 2017 6:43 AM, "Enr
Hi all,
as you can see from github emails there is an ongoing proposal to add
"checkstyle" plugin to BookKeeper build.
I am really in favour of this change. It is already used in
DistributedLog and it will ease the review, preventing us from writing
comments for minor typos.
https://github.com/apa
