Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-29 Thread ZhangJian He
Hi Lari, Thanks for your nice explanation and work in https://github.com/apache/bookkeeper/pull/4197. >> Summary: let's use Junit 5 & AssertJ for all new tests and migrate from Junit 4 to Junit 5 when that provides some value (for example parameterized tests). I agree, and leverage annotation feat

Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-29 Thread Lari Hotari
Support for JUnit 5 tests was added in https://github.com/apache/bookkeeper/pull/4197. Junit 4 and Junit 5 tests can co-exist in the code base. Junit 5 (Jupiter) test runner is used for test execution. While switching to use Junit 5, it's worth considering primarily using AssertJ for more comp

Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-29 Thread ZhangJian He
>> Please ensure that on CI we always both the 2 families of tests until we completed the migration It works well. Yes, Like in workflow https://github.com/apache/bookkeeper/actions/runs/8873903044/job/24360578932. TestDirectReader,TestDirectWriter runs normally, and they are already junit5. I cr

Re: [discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-28 Thread Enrico Olivelli
ZhangJian Il giorno mer 24 apr 2024 alle ore 18:58 ZhangJian He ha scritto: > I am reaching out to propose a gradual migration of our testing framework > from JUnit 4 to JUnit 5 across the BookKeeper. JUnit 5 offers significant > improvements over JUnit 4, including more powerful and flexible te

[discuss] Proposal to Gradually Migrate from JUnit 4 to JUnit 5

2024-04-24 Thread ZhangJian He
I am reaching out to propose a gradual migration of our testing framework from JUnit 4 to JUnit 5 across the BookKeeper. JUnit 5 offers significant improvements over JUnit 4, including more powerful and flexible testing capabilities like annotation-based coding(so we don't need to write assume), pa