Re: [VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread Wenbing Shen
+1(non-binding) Thanks Wenbing ZhangJian He 于2023年3月21日周二 09:53写道: > +1(non-binding) > > Thanks > ZhangJian He > > > On Tue, 21 Mar 2023 at 08:11, Andrey Yegorov > wrote: > > > Overall, +1. > > I do have some concerns related to handling various limiters, so I left a > > comment on the PR. > >

Re: [VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread ZhangJian He
+1(non-binding) Thanks ZhangJian He On Tue, 21 Mar 2023 at 08:11, Andrey Yegorov wrote: > Overall, +1. > I do have some concerns related to handling various limiters, so I left a > comment on the PR. > > On Mon, Mar 20, 2023 at 6:05 AM Hang Chen wrote: > > > This is the vote for BP-62. > > >

Re: [VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread Andrey Yegorov
Overall, +1. I do have some concerns related to handling various limiters, so I left a comment on the PR. On Mon, Mar 20, 2023 at 6:05 AM Hang Chen wrote: > This is the vote for BP-62. > > ### Motivation > The bookie server process add-entry requests pipeline: > - Get one request from the Netty

Re: [VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread Matteo Merli
+1 -- Matteo Merli On Mon, Mar 20, 2023 at 6:05 AM Hang Chen wrote: > This is the vote for BP-62. > > ### Motivation > The bookie server process add-entry requests pipeline: > - Get one request from the Netty socket channel > - Choose one thread to process the written request > - Write the ent

[VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread Hang Chen
This is the vote for BP-62. ### Motivation The bookie server process add-entry requests pipeline: - Get one request from the Netty socket channel - Choose one thread to process the written request - Write the entry into the target ledger entry logger's write cache(memory table) - Put the entry int