Re: [VOTE] BP-15 New CreateLedger API

2017-09-18 Thread Enrico Olivelli
Hi all, during the discussion on the patch for the new LedgerAPI there is an important decision which arose https://github.com/apache/bookkeeper/pull/510 Should we drop the legacy AsyncCallbacks from the new WriteHandler/ReadHandler APIs ? We are introducing CompletableFuture and this is great, b

Re: [VOTE] BP-15 New CreateLedger API

2017-09-14 Thread Enrico Olivelli
This is the PR https://github.com/apache/bookkeeper/pull/510 Enrico 2017-09-14 12:51 GMT+02:00 Enrico Olivelli : > The patch is ready > Please checkout an comment and possibly merge :-) > > minor details: > - I have not used the Netty4 "recycler" because we are using directly > CreateLedgerOp (a

Re: [VOTE] BP-15 New CreateLedger API

2017-09-14 Thread Enrico Olivelli
The patch is ready Please checkout an comment and possibly merge :-) minor details: - I have not used the Netty4 "recycler" because we are using directly CreateLedgerOp (and similar) so the memory footprint is exactly the same as 4.5, we can add it in the future (or backport Yahoo improvements fro

Re: [VOTE] BP-15 New CreateLedger API

2017-09-12 Thread Enrico Olivelli
Yep We can review the details directly on the patch. Additionally: I think a separate issue will be created, like "Documentation of the new API on the website" Enrico 2017-09-12 10:07 GMT+02:00 Sijie Guo : > cool. just remember to put the new interfaces under > org.apache.bookkeeper.client.api

Re: [VOTE] BP-15 New CreateLedger API

2017-09-12 Thread Sijie Guo
cool. just remember to put the new interfaces under org.apache.bookkeeper.client.api. so we can separate client and server module in future. - Sijie On Tue, Sep 12, 2017 at 1:04 AM, Enrico Olivelli wrote: > OK, as there is not -1 I am marking this proposal as "Accepted". > > Thank you Jia and S

Re: [VOTE] BP-15 New CreateLedger API

2017-09-12 Thread Enrico Olivelli
OK, as there is not -1 I am marking this proposal as "Accepted". Thank you Jia and Sijie for voting and for comments from other guys at the meeting. I wlil create and issue and send a pull request soon. It will take some time as we need tons of JavaDocs, we are going to introduce many *public *ne

Re: [VOTE] BP-15 New CreateLedger API

2017-09-11 Thread Sijie Guo
Enrico, Feel free to close the vote if there is no -1. BP approval is a lazy approval with no -1. - Sijie On Mon, Sep 11, 2017 at 2:27 AM, Enrico Olivelli wrote: > Ping > > 2017-09-08 6:28 GMT+02:00 Jia Zhai : > > > +1 for the new design. > > > > On Thu, Sep 7, 2017 at 3:49 AM, Enrico Olivelli

Re: [VOTE] BP-15 New CreateLedger API

2017-09-11 Thread Sijie Guo
+1 On Wed, Sep 6, 2017 at 12:49 PM, Enrico Olivelli wrote: > Hi all, > I would like to call a vote for this BookKeeper proposal > > This is the wiki page > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > BP-15+New+CreateLedger+API > > It is a new Client API for creating/opening ledgers

Re: [VOTE] BP-15 New CreateLedger API

2017-09-11 Thread Enrico Olivelli
Ping 2017-09-08 6:28 GMT+02:00 Jia Zhai : > +1 for the new design. > > On Thu, Sep 7, 2017 at 3:49 AM, Enrico Olivelli > wrote: > > > Hi all, > > I would like to call a vote for this BookKeeper proposal > > > > This is the wiki page > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > >

Re: [VOTE] BP-15 New CreateLedger API

2017-09-07 Thread Jia Zhai
+1 for the new design. On Thu, Sep 7, 2017 at 3:49 AM, Enrico Olivelli wrote: > Hi all, > I would like to call a vote for this BookKeeper proposal > > This is the wiki page > https://cwiki.apache.org/confluence/display/BOOKKEEPER/ > BP-15+New+CreateLedger+API > > It is a new Client API for creat

[VOTE] BP-15 New CreateLedger API

2017-09-06 Thread Enrico Olivelli
Hi all, I would like to call a vote for this BookKeeper proposal This is the wiki page https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-15+New+CreateLedger+API It is a new Client API for creating/opening ledgers. We are going to have separate interfaces for Writers and Readers and we are