Re: [VOTE] Apache BookKeeper Release 4.5.1, release candidate #1

2017-11-15 Thread David Rusek
+1 -sha, md5 check out -built source -binary package verified -Dave On Wed, Nov 15, 2017 at 11:40 AM Sijie Guo wrote: > +1 > > - sha, md5, signatures are alll good > - licence header checking is good > - pass findbugs > - built source package and run all tests > - binary package distribution l

Re: [VOTE] Apache BookKeeper Release 4.5.1, release candidate #1

2017-11-15 Thread Sijie Guo
+1 - sha, md5, signatures are alll good - licence header checking is good - pass findbugs - built source package and run all tests - binary package distribution looks good - Sijie On Tue, Nov 14, 2017 at 9:11 AM, Enrico Olivelli wrote: > Hi everyone, > Please review and vote on the release can

Re: [VOTE] Apache BookKeeper Release 4.5.1, release candidate #1

2017-11-15 Thread Ivan Kelly
+1 from me - Sha, md5, gpg signatures are good - rat & findbugs pass - tests pass eventually (TestRackawareEnsemblePlacementPolicyUsingScript is still flakey as hell) - Code matches the tag - NOTICE file in binary looks good - LICENSE file in binary looks mostly good (there's still a reference to

Re: [VOTE] Apache BookKeeper Release 4.5.1, release candidate #1

2017-11-14 Thread Jia Zhai
+1, - verified packages checksum (md5, asc and sha1 all good) - the source package build and test all run successfully. - NOTICE, DISCLAIME, License headers in binary package look good. On Wed, Nov 15, 2017 at 1:11 AM, Enrico Olivelli wrote: > Hi everyone, > Please review and vote on the relea

[VOTE] Apache BookKeeper Release 4.5.1, release candidate #1

2017-11-14 Thread Enrico Olivelli
Hi everyone, Please review and vote on the release candidate #1 for the version 4.5.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The off