[GitHub] bookkeeper pull request: BOOKKEEPER-855: handle session expire eve...

2015-12-02 Thread merlimat
Github user merlimat commented on the pull request: https://github.com/apache/bookkeeper/pull/1#issuecomment-161300318 Looks good to me, just the executor shutdown thing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] bookkeeper pull request: BOOKKEEPER-855: handle session expire eve...

2015-12-02 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/bookkeeper/pull/1#discussion_r46415317 --- Diff: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java --- @@ -142,7 +145,11 @@ final protected String zkBookieRegPath