Re: [DISCUSS] Unify the import order in bookkeeper

2022-07-29 Thread Enrico Olivelli
I am fine with fixing the import order. the patch is still huge, but it is doable I will review the patch and give my feedback thanks Enrico Il giorno ven 29 lug 2022 alle ore 05:48 ZhangJian He ha scritto: > > https://github.com/apache/bookkeeper/pull/3311 is ready for review. > > Thanks > Zh

Re: [DISCUSS] Unify the import order in bookkeeper

2022-07-28 Thread ZhangJian He
https://github.com/apache/bookkeeper/pull/3311 is ready for review. Thanks ZhangJian He On Sun, 5 Jun 2022 at 16:43, ZhangJian He wrote: > Hi community, I want to open a discussion about importOrder in bookkeeper. > > Currently, we use puppycrawl checkstyle 6.19, which is not strictly verify >

[DISCUSS] Unify the import order in bookkeeper

2022-06-05 Thread ZhangJian He
Hi community, I want to open a discussion about importOrder in bookkeeper. Currently, we use puppycrawl checkstyle 6.19, which is not strictly verify the import order. In the recently checkstyle version, it needs a strictly ImportOrder verify if configs[1]. In simple terms, our config ImportOrder