Good idea @Lamber-Ken,
I created a PR that merge java.util.Optional and com.google.common.base.Optional
https://github.com/apache/bookkeeper/pull/2346/commits
Matteo.
Il giorno 21/05/20, 12:34 "Lamber-Ken" ha scritto:
Dear community,
I noticed that there is a lot of work to improve
> It is better to split the work in several patches, this way we can make
> review simpler
Sure, will do.
Best,
Lamber-Ken
On 2020/05/21 10:37:38, Enrico Olivelli wrote:
> Il Gio 21 Mag 2020, 12:34 Lamber-Ken ha scritto:
>
> > Dear community,
> >
> > I noticed that there is a lot of work to
Il Gio 21 Mag 2020, 12:34 Lamber-Ken ha scritto:
> Dear community,
>
> I noticed that there is a lot of work to improve code quality.
>
It would be very welcome!
Thanks
> e.g
> 1. Not enough arguments.
> LOG.warn("Exception when reading header of {} : {}", lf, buf);
> 2. Optional.
> java.
Dear community,
I noticed that there is a lot of work to improve code quality.
e.g
1. Not enough arguments.
LOG.warn("Exception when reading header of {} : {}", lf, buf);
2. Optional.
java.util.Optional and com.google.common.base.Optional can be merged.
3. @Slf4j
@Slf4j / LoggerFactory.getL
