[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/214 @eolivelli Please confirm if your branch is different than bookkeeper master. From the stack trace in Journal.run() there seems to be a line of code releasing ByteBuf. I don't see th

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/issues/198 Enrico, Found a few refcount leaks, fixed them and created a pull request. I couldn't reproduce the test failure locally. So, could you please check and let me know if

[GitHub] bookkeeper pull request #214: Fix ByteBuf refcount release

GitHub user kishorekasi opened a pull request: https://github.com/apache/bookkeeper/pull/214 Fix ByteBuf refcount release - Release ByteBuf in Replicator - Do not release refcnt in PCBC upon addEntry error - Remove unnecessary ByteBuf refcnt retain in Bookie protocol (V2

[GitHub] bookkeeper issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/183 Updated the pull request. I am not able to reproduced the previous jenkins failure locally. With this new update I will wait for the jenkins run to check if the failures are repeatable

[GitHub] bookkeeper issue #198: TestBackwardCompat.testCompat410 often fails due to i...

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/issues/198 Enrico, Let me look into this. Kishore On Wed, Jun 21, 2017 at 7:21 AM, Enrico Olivelli wrote: > @merlimat <https://github.com/merlimat> @ki

[GitHub] bookkeeper pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

GitHub user kishorekasi opened a pull request: https://github.com/apache/bookkeeper/pull/183 BOOKKEEPER-588 SSL Support for Bookkeeper + Merged changes from @eoliville + Mutual Authentication You can merge this pull request into a Git repository by running: $ git pull

[GitHub] bookkeeper issue #97: BOOKKEEPER-588 SSL Support

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/97 Hi Sijie, I have some more testing to complete. I will work on it this weekend and post a pull request. Kishore Sent from my iPhone > On May

[GitHub] bookkeeper issue #97: BOOKKEEPER-588 SSL Support

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/97 Sorry, typo. I will generate a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] bookkeeper issue #97: BOOKKEEPER-588 SSL Support

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/97 Enrico, I have generate a pull request combing both our changes. Kishore Sent from my iPhone > On May 17, 2017, at 8:29 AM, Enrico Olivelli wr

[GitHub] bookkeeper pull request #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi closed the pull request at: https://github.com/apache/bookkeeper/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli I have not looked into @merlimat changes. I will take a look and add them if they are not already addressed. --- If your project is set up for it, you can reply to this email and

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli @sijie @merlimat With my latest commit this evening, all tests seem to pass now. Let me know if you are seeing any test failures in your local runs. --- If your project is set

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @revans2 I have seen "too many open files" in the past. Recently I have not seen them. But, I had to increase ulimit on my dev machines for a different reason. That explains wh

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Thanks @merlimat I will pick those changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 @eolivelli - I fixed a refcnt bug with ByteBuf and consistently pass SlowBookieTest now; updated the pull request. I am not able to see the jenkins build output, waiting for this next run to

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 I fixed a merge conflict. Also as Netty channel and write and flush semantics have changed in 4.x; made few more changes. --- If your project is set up for it, you can reply to this email

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Yes @merlimat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Just back from vacation. There seems to be new commits to the repo. I will resolve the conflicts and generate a new pull request. --- If your project is set up for it, you can reply to this

[GitHub] bookkeeper issue #116: BOOKKEEPER-1008 Move to Netty4.1

Github user kishorekasi commented on the issue: https://github.com/apache/bookkeeper/pull/116 Enrico, I have updated the pull request with my local changes. Kishore > On Apr 10, 2017, at 5:42 AM, Enrico Olivelli wrote: > > @kishorekasi