Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-30 Thread Horizon
Hi, Enrico. Just confirm, only revert https://github.com/apache/bookkeeper/pull/3528, it work well? > 2023年1月30日 16:04,Enrico Olivelli 写道: > > I think that we must do something, current master branch is not stable. > > My colleague Massimiliano opened this issue > https://github.com/apache/boo

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-30 Thread Shiji Lu
+1 , use new specification (ReferenceCountUtil.release) replace BP-59 On 2023/01/30 09:24:03 Shiji Lu wrote: > Good suggestions, > We currently have several ways to fix this problem, revert all previous PRs, > or directly replace them with new standard methods, I am ok, we can vote. > > I think

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-30 Thread Shiji Lu
Good suggestions, We currently have several ways to fix this problem, revert all previous PRs, or directly replace them with new standard methods, I am ok, we can vote. I think one specification can be used at present, all of which are released in the way of ReferenceCountUtil.release, replacing

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-30 Thread Shiji Lu
Good suggestions, We currently have several ways to fix this problem, revert all previous PRs, or directly replace them with new standard methods, I am ok, we can vote. I think one specification can be used at present, all of which are released in the way of ReferenceCountUtil.release, replacing

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-30 Thread Enrico Olivelli
I think that we must do something, current master branch is not stable. My colleague Massimiliano opened this issue https://github.com/apache/bookkeeper/issues/3751 Basically in the current master there is some problem that leads to Netty BytBuf corruption. The problem is solved by reverting thi