Re: NPE in pendingAddOp

sure, unless some other corner case of Op completion is missing. Doing something along the lines of the code below will add some visibility into that: void timeoutQuorumWait() { try { if(!completed) final LedgerHandle cached = lh; clientCtx.getMainWorkerPool().executeOrdered(lh.ledgerId, new SafeR

Re: NPE in pendingAddOp

But post recycle should not result in this scenario as I mentioned in my comment. On Tue, Feb 16, 2021 at 2:49 PM Andrey Yegorov wrote: > Simple check for null won't prevent timing out wrong (post recycle/reuse) > handle. > > > On Tue, Feb 16, 2021 at 14:38 Venkateswara Rao Jujjuri > wrote: > >

Re: NPE in pendingAddOp

Simple check for null won't prevent timing out wrong (post recycle/reuse) handle. On Tue, Feb 16, 2021 at 14:38 Venkateswara Rao Jujjuri wrote: > Yes; That is exactly how my theory is and the fix is also the same. But > still looking into how we could get into it. > > // If the object is recycl

Re: NPE in pendingAddOp

Yes; That is exactly how my theory is and the fix is also the same. But still looking into how we could get into it. // If the object is recycled while this task is on the queue lh could get null. // monitorPendingAddOps() can't schedule after recycling because // time timed out pendingAddOp won't

Re: NPE in pendingAddOp

This could happen if PendingAddOp got recycled (and set lh to null) before the runnable submitted by timeoutQuorumWait had a chance to run. I don't know how it got into this state but if is easy to miss if recycled object gets reused quickly - timeout will fail wrong ledger. The right thing to do

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

PR 2604 for the docs/release notes update On Tue, Feb 16, 2021 at 13:10 Enrico Olivelli wrote: > Il giorno mar 16 feb 2021 alle ore 21:23 Andrey Yegorov < > andrey.yego...@gmail.com> ha scritto: > > > One thing to clarify from the release instructions: > > > > Is my understanding correct that "C

Re: NPE in pendingAddOp

Sorry I never seen that error Enrico Il giorno mar 16 feb 2021 alle ore 19:50 Venkateswara Rao Jujjuri < jujj...@gmail.com> ha scritto: > Ignore my comment about different thread, I see that timeoutQuorumWait() is > run through OSE. > But we did NPE in this line > < > https://github.com/apache/b

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

Il giorno mar 16 feb 2021 alle ore 21:23 Andrey Yegorov < andrey.yego...@gmail.com> ha scritto: > One thing to clarify from the release instructions: > > Is my understanding correct that "Create CI jobs for release branch" step > is obsolete as we moved to GitHub actions? I.e. I don't see any > co

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

One thing to clarify from the release instructions: Is my understanding correct that "Create CI jobs for release branch" step is obsolete as we moved to GitHub actions? I.e. I don't see any corresponding changes in Jenkins for release 4.12. On Tue, Feb 16, 2021 at 12:04 Enrico Olivelli wrote: >

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

Il giorno mar 16 feb 2021 alle ore 20:22 Andrey Yegorov < andrey.yego...@gmail.com> ha scritto: > I'll appreciate if someone could add me ("ayegorov") as a maintainer to the > PyPi bookkeeper-client. > Sure. I will do it Enrico > > I am setting up my environment for the release and this is one

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

I'll appreciate if someone could add me ("ayegorov") as a maintainer to the PyPi bookkeeper-client. I am setting up my environment for the release and this is one of the steps listed in the release guide. On Tue, Feb 16, 2021 at 09:32 Andrey Yegorov wrote: > I'll do the release. > > On Sun, Feb

Re: NPE in pendingAddOp

Ignore my comment about different thread, I see that timeoutQuorumWait() is run through OSE. But we did NPE in this line . In this run, we have disabled ensemble cha

NPE in pendingAddOp

We have observed NPE in pendingAddOp in this line . This looks like a race between execution of recyclePendAddOpObject() in OSE context and maybeTimeout() in monito

Re: Cutting BookKeeper 4.13.0 ? Ticket to add to the list ?

I'll do the release. On Sun, Feb 14, 2021 at 23:31 Enrico Olivelli wrote: > We are done with the fixes around LICENSE files. > > > > Il giorno ven 12 feb 2021 alle ore 18:47 Andrey Yegorov < > andrey.yego...@gmail.com> ha scritto: > > > I sent PR for dropwizard upgrade. > > > > License files are