Re: Iterable

2017-11-02 Thread Enrico Olivelli
Jia I think we must do this before releasing 4.6 Enrico Il ven 3 nov 2017, 06:48 Enrico Olivelli ha scritto: > > > Il ven 3 nov 2017, 02:39 Sijie Guo ha scritto: > >> Hi Enrico, >> >> In the new ledger api, we return Iterable instead of >> Iterator. In general, it is good to return Iterable, h

Re: Iterable

2017-11-02 Thread Enrico Olivelli
Il ven 3 nov 2017, 02:39 Sijie Guo ha scritto: > Hi Enrico, > > In the new ledger api, we return Iterable instead of > Iterator. In general, it is good to return Iterable, however > it seems to be problematic in following use case: > > Iterable entries = rh.read(...); > > Iterator iter1 = entries

Code freeze for apache bookkeeper 4.6.0 release

2017-11-02 Thread Jia Zhai
Hi all, According to the release plan of apache bookkeeper, I would like to call a code freeze for release 4.6.0. 1, We will create new branch this weekend. 2, No more feature issue should be marked as 4.6.0; any new feature should be marked as 4.7.0. 3, Bug fix issues, which are really needed, co

Iterable

2017-11-02 Thread Sijie Guo
Hi Enrico, In the new ledger api, we return Iterable instead of Iterator. In general, it is good to return Iterable, however it seems to be problematic in following use case: Iterable entries = rh.read(...); Iterator iter1 = entries.iterator(); while (iter1.hasNext()) { LedgerEntry le = iter1.n

Re: Cutting 4.5.1 release

2017-11-02 Thread Ivan Kelly
> I wonder if I should create a pull request in order to bump the > 4.5.1-SNAPSHOT and wait for approval. 4.5.1-SNAPSHOT is not needed and would serve no purpose. > Do we have to log in git history: > - the presence of a 4.5.1-SNAPSHOT > - the presence of a 4.5.1 version > In the branch-4.5 > > Or

Re: Cutting 4.5.1 release

2017-11-02 Thread Enrico Olivelli
Il gio 2 nov 2017, 12:57 Enrico Olivelli ha scritto: > Another odd think in branch-4.5 > > we have currently poms at version 4.5.0-SNAPSHOT > > https://github.com/apache/bookkeeper/blob/branch-4.5/pom.xml > > it should be 4.5.1-SNASHOT in my opinion. > > During the release of 4.5.1 I will fix thi

length issue in ledger handle adv

2017-11-02 Thread Sijie Guo
Hi JV, As we discussed in the meeting, this is the issue and fix for length issue in LedgerHandleAdv : https://github.com/apache/bookkeeper/pull/684 - Sijie

Re: Draft Agenda for Bi-weekly meeting at 2017-11-02

2017-11-02 Thread Enrico Olivelli
I apologize. Due to DST changes in my timezone I missed the meeting ! Enrico 2017-11-02 16:43 GMT+01:00 Jia Zhai : > have updated the meeting notes here > 2017-11-02+Meeting+Notes>, > if you find there is something missing, please help

Re: Draft Agenda for Bi-weekly meeting at 2017-11-02

2017-11-02 Thread Jia Zhai
have updated the meeting notes here , if you find there is something missing, please help add it. :) = *Agenda:* 1. discuss status of release 4.5.1 and 4.6.0 2. Flaky Tests status 3

Re: Cutting 4.5.1 release

2017-11-02 Thread Enrico Olivelli
Another odd think in branch-4.5 we have currently poms at version 4.5.0-SNAPSHOT https://github.com/apache/bookkeeper/blob/branch-4.5/pom.xml it should be 4.5.1-SNASHOT in my opinion. During the release of 4.5.1 I will fix this. @Sijie @Ivan Do you think we should fix this before starting the

Re: bookkeeper dist package

2017-11-02 Thread Enrico Olivelli
2017-11-02 10:11 GMT+01:00 Sijie Guo : > On Thu, Nov 2, 2017 at 12:44 AM, Enrico Olivelli > wrote: > > > 2017-11-02 8:34 GMT+01:00 Sijie Guo : > > > > > Hi all, > > > > > > in apache/bookkeeper#499 > bookkeeper/issues/499 > > > >, > > > we moved packaging distributio

Re: bookkeeper dist package

2017-11-02 Thread Sijie Guo
On Thu, Nov 2, 2017 at 12:44 AM, Enrico Olivelli wrote: > 2017-11-02 8:34 GMT+01:00 Sijie Guo : > > > Hi all, > > > > in apache/bookkeeper#499 bookkeeper/issues/499 > > >, > > we moved packaging distribution pkgs from bookkeeper-server to > > bookkeeper-dist and incl

Re: bookkeeper dist package

2017-11-02 Thread Enrico Olivelli
2017-11-02 8:34 GMT+01:00 Sijie Guo : > Hi all, > > in apache/bookkeeper#499 >, > we moved packaging distribution pkgs from bookkeeper-server to > bookkeeper-dist and included all the plugins. so people can choose which > stats provider and which

bookkeeper dist package

2017-11-02 Thread Sijie Guo
Hi all, in apache/bookkeeper#499 , we moved packaging distribution pkgs from bookkeeper-server to bookkeeper-dist and included all the plugins. so people can choose which stats provider and which http server binding to use. It provides the flexibili