Charan this looks like an issue to me. Do we have a defect/issue opened?
On Fri, Oct 13, 2017 at 4:18 PM, Sijie Guo wrote:
> Charan,
>
> Didn't mean to say the logic is correct. I was just trying to point out
> the points that I remembered for checkpoint.
>
> I am currently traveling, so I don't
Charan,
Didn't mean to say the logic is correct. I was just trying to point out the
points that I remembered for checkpoint.
I am currently traveling, so I don't have code available to check the
sequence. I can check the logic when I am close to the laptop.
Sijie
On Oct 14, 2017 6:11 AM, "Char
Hey Sijie,
I'm not questioning the semantics of checkpoint or the optimization which
was added with Bookkeeper-564. But my concern is are we sure, checkpoint
logic/code is correct and "marker is only updated when all the entries
added before are persisted.", in the case of SortedLedgerStorage. Can
The core of the checkpoint is:
- marker is only updated when all the entries added before are persisted.
That means it doesn't affect correctness if entries added after are flushed.
- the flush in entry log files is just writing data to filesystem. The real
fsync happens after checkpoint. The sep
With a tally of 5 +1s from active committers and no -1, the vote passes.
I'll start the process of writing a script to move stuff over.
-Ivan
On Mon, Oct 9, 2017 at 7:21 PM, Matteo Merli wrote:
> +1
>
> On Mon, Oct 9, 2017 at 10:08 AM Sijie Guo wrote:
>
>> +1
>>
>> On Mon, Oct 9, 2017 at 2:16
