Re: BP-15 New CreateLeader API

2017-09-01 Thread Enrico Olivelli
2017-09-01 12:21 GMT+02:00 Sijie Guo : > On Fri, Sep 1, 2017 at 3:04 AM, Enrico Olivelli > wrote: > > > 2017-09-01 11:58 GMT+02:00 Sijie Guo : > > > > > On Fri, Sep 1, 2017 at 2:50 AM, Enrico Olivelli > > > wrote: > > > > > > > Thank you Sijie for taking a look so quickly > > > > > > > > My prop

Re: BP-15 New CreateLeader API

2017-09-01 Thread Sijie Guo
On Fri, Sep 1, 2017 at 3:04 AM, Enrico Olivelli wrote: > 2017-09-01 11:58 GMT+02:00 Sijie Guo : > > > On Fri, Sep 1, 2017 at 2:50 AM, Enrico Olivelli > > wrote: > > > > > Thank you Sijie for taking a look so quickly > > > > > > My proposal was only narrowed to the CreateLedger API, but I see you

Re: BP-15 New CreateLeader API

2017-09-01 Thread Enrico Olivelli
2017-09-01 11:58 GMT+02:00 Sijie Guo : > On Fri, Sep 1, 2017 at 2:50 AM, Enrico Olivelli > wrote: > > > Thank you Sijie for taking a look so quickly > > > > My proposal was only narrowed to the CreateLedger API, but I see your > > approach is really more straightforward and I like it very much.

Re: BP-15 New CreateLeader API

2017-09-01 Thread Sijie Guo
It will be good to see others' opinons before you updating the proposal. - Sijie On Fri, Sep 1, 2017 at 2:58 AM, Sijie Guo wrote: > > > On Fri, Sep 1, 2017 at 2:50 AM, Enrico Olivelli > wrote: > >> Thank you Sijie for taking a look so quickly >> >> My proposal was only narrowed to the CreateLe

Re: BP-15 New CreateLeader API

2017-09-01 Thread Sijie Guo
On Fri, Sep 1, 2017 at 2:50 AM, Enrico Olivelli wrote: > Thank you Sijie for taking a look so quickly > > My proposal was only narrowed to the CreateLedger API, but I see your > approach is really more straightforward and I like it very much. > I have introduced the LedgerConfiguration bean in o

Re: BP-15 New CreateLeader API

2017-09-01 Thread Enrico Olivelli
Thank you Sijie for taking a look so quickly My proposal was only narrowed to the CreateLedger API, but I see your approach is really more straightforward and I like it very much. I have introduced the LedgerConfiguration bean in order to have some "template" for creating ledgers, you proposal is

Re: BP-15 New CreateLeader API

2017-09-01 Thread Sijie Guo
hmm, I actually like the alternative you rejected. Instead, I don't think the approach in the proposal is the right one that we should take. 1) LedgerConfiguration is a confusing term used here. what doest a `configuration` mean here, is the configuration stored somewhere or just purely runtime co

Re: BP-15 New CreateLeader API

2017-09-01 Thread Enrico Olivelli
sorry for typo in the title of the page this is the good link, it is "CreateLedger" https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-15+New+CreateLedger+API -- Enrico 2017-09-01 10:33 GMT+02:00 Enrico Olivelli : > Hi all, > I have just posted a proposal to introduce a new createLedger

BP-15 New CreateLeader API

2017-09-01 Thread Enrico Olivelli
Hi all, I have just posted a proposal to introduce a new createLedger API using the 'builder' design pattern. https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-15+New+CreateLeader+API This is a pre-requisite for BP-14 Relax Durability and for LedgerType improvements It is a trivial chang

Re: Docker images

2017-09-01 Thread Francesco Caliumi - Diennea
Yes, it seems I have full permissions now. Thanks Sijie. On Thu, 2017-08-31 at 23:48 -0700, Sijie Guo wrote: hmm, I am not sure. I changed the permissions to admin for you and Jia. Let me know if you have permissions now? - Sijie On Thu, Aug 31, 2017 at 11:45 PM, Francesco Caliumi - Diennea < f