[GitHub] sijie opened a new issue #395: GSSAPIBookKeeperTest failed on jenkins

2017-08-04 Thread git
sijie opened a new issue #395: GSSAPIBookKeeperTest failed on jenkins URL: https://github.com/apache/bookkeeper/issues/395 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? trigger pullrequest-precommit CI job - What did you expect to se

[GitHub] sijie closed issue #393: [CI] publish-website job will be marked as failure if it is an empty commit

2017-08-04 Thread git
sijie closed issue #393: [CI] publish-website job will be marked as failure if it is an empty commit URL: https://github.com/apache/bookkeeper/issues/393 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #394: Issue 393: [CI] publish-website job will be marked as failure if it is an empty commit

2017-08-04 Thread git
sijie closed pull request #394: Issue 393: [CI] publish-website job will be marked as failure if it is an empty commit URL: https://github.com/apache/bookkeeper/pull/394 This is an automated message from the Apache Git Serv

[GitHub] sijie opened a new pull request #394: Issue 393: [CI] publish-website job will be marked as failure if it is an empty commit

2017-08-04 Thread git
sijie opened a new pull request #394: Issue 393: [CI] publish-website job will be marked as failure if it is an empty commit URL: https://github.com/apache/bookkeeper/pull/394 Descriptions of the changes in this PR: - use `git diff-index` to checkout if there is any changes to commit

[GitHub] sijie opened a new issue #393: [CI] publish-website job will be marked as failure if it is an empty commit

2017-08-04 Thread git
sijie opened a new issue #393: [CI] publish-website job will be marked as failure if it is an empty commit URL: https://github.com/apache/bookkeeper/issues/393 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run publish-website ci job on pos

Re: bookkeeper website from cms to git

2017-08-04 Thread Sijie Guo
Cool. I will leave this discussion open for a few days. If there is no objections, I will talk to INFRA guys on Monday to ask them cut the website from CMS to Git. - Sijie On Thu, Aug 3, 2017 at 11:05 PM, Enrico Olivelli wrote: > Il ven 4 ago 2017, 07:56 Sijie Guo ha scritto: > > > I've done c

Jenkins build is back to normal : bookkeeper-postcommit-publish-website #34

2017-08-04 Thread Apache Jenkins Server
See

[GitHub] sijie closed issue #367: [documentation] readUnconfirmedEntries

2017-08-04 Thread git
sijie closed issue #367: [documentation] readUnconfirmedEntries URL: https://github.com/apache/bookkeeper/issues/367 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] sijie closed pull request #371: Issue 367: [documentation] add api readUnconfirmedEntries in website doc

2017-08-04 Thread git
sijie closed pull request #371: Issue 367: [documentation] add api readUnconfirmedEntries in website doc URL: https://github.com/apache/bookkeeper/pull/371 This is an automated message from the Apache Git Service. To respon

Build failed in Jenkins: bookkeeper-postcommit-publish-website #33

2017-08-04 Thread Apache Jenkins Server
See Changes: [jiazhai] ISSUE #391: CI failed with java.lang.ClassNotFoundException: -- [...truncated 100.75 KB...] [WARNING]

[GitHub] jiazhai closed pull request #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
jiazhai closed pull request #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/pull/392 This is an automated message from the Apache Git S

[GitHub] jiazhai closed issue #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
jiazhai closed issue #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/issues/391 This is an automated message from the Apache Git Service. To respo

Re: Build failed in Jenkins: bookkeeper-postcommit-publish-website #32

2017-08-04 Thread Sijie Guo
Hmm, an empty commit seems to be marked as failure. Let me see how to mitigate this. - Sijie On Fri, Aug 4, 2017 at 1:55 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See publish-website/32/display/redirect?page=changes> >

Build failed in Jenkins: bookkeeper-postcommit-publish-website #32

2017-08-04 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #383: mvn release:branch fails -- [...truncated 98.10 KB...] [WARNING]

[GitHub] sijie closed issue #383: mvn release:branch fails

2017-08-04 Thread git
sijie closed issue #383: mvn release:branch fails URL: https://github.com/apache/bookkeeper/issues/383 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] sijie closed pull request #384: Issue 383: mvn release:branch fails

2017-08-04 Thread git
sijie closed pull request #384: Issue 383: mvn release:branch fails URL: https://github.com/apache/bookkeeper/pull/384 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
sijie commented on issue #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/pull/392#issuecomment-320348828 declare the junit dependencies in root pom -

[GitHub] sijie commented on issue #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
sijie commented on issue #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/pull/392#issuecomment-320346105 I run the branch in a test ci job - https://builds.apache.org/view/BK/job/bookkeeper-test2/5/

[GitHub] sijie opened a new pull request #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
sijie opened a new pull request #392: Issue 391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/pull/392 Descriptions of the changes in this PR: - include hamcrest dependency for tests (according to [junit](http

[GitHub] sijie opened a new issue #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing

2017-08-04 Thread git
sijie opened a new issue #391: CI failed with java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing URL: https://github.com/apache/bookkeeper/issues/391 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Trigger the ci build on bookkeep

Re: BookKeeper and code-coverage - JaCoco

2017-08-04 Thread Sijie Guo
Sure go for it. Sijie On Aug 4, 2017 12:46 PM, "Enrico Olivelli" wrote: > Il gio 20 lug 2017, 17:06 Enrico Olivelli ha > scritto: > > > Jacoco is running as expected > > see: > > https://coveralls.io/jobs/27785961 > > > > I think it is better to switch to Jacoco > > > > I wonder why on DL ther

Re: BookKeeper and code-coverage - JaCoco

2017-08-04 Thread Enrico Olivelli
Il gio 20 lug 2017, 17:06 Enrico Olivelli ha scritto: > Jacoco is running as expected > see: > https://coveralls.io/jobs/27785961 > > I think it is better to switch to Jacoco > > I wonder why on DL there is no such problem with Cobertura > @Sijie do you have any idea ? > Other opinions? I am goi

Re: CI

2017-08-04 Thread Enrico Olivelli
Il lun 31 lug 2017, 23:38 Sijie Guo ha scritto: > Also I am not good at jenkins job builder. So if any people is good at > jenkins job builder and willing to help the community to convert those jobs > to use jenkins job builder, that would be great. > Sure Sorry for late reply. If not too late I

[GitHub] eolivelli closed issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli closed issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/issues/388 This is an automated message from the Apache Git Service. To respond to

[GitHub] eolivelli closed pull request #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli closed pull request #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/pull/389 This is an automated message from the Apache Git Se

[GitHub] eolivelli commented on issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli commented on issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/issues/388#issuecomment-320312453 As discussed in the mailing list this change will not add real improvements and could change the behaviour of

[GitHub] sijie commented on issue #387: Support SASL SCRAM authentication

2017-08-04 Thread git
sijie commented on issue #387: Support SASL SCRAM authentication URL: https://github.com/apache/bookkeeper/issues/387#issuecomment-320312193 @eolivelli yes. done. This is an automated message from the Apache Git Service. To r

Re: Digests are computed inside the mailWorkerPool

2017-08-04 Thread Enrico Olivelli
Il ven 4 ago 2017, 19:29 Sijie Guo ha scritto: > On Fri, Aug 4, 2017 at 8:50 AM, Enrico Olivelli > wrote: > > > 2017-08-04 17:38 GMT+02:00 Sijie Guo : > > > > > On Aug 4, 2017 5:27 AM, "Enrico Olivelli" wrote: > > > > > > Hi bookkeepers, > > > I noticed that digests are computed on the mailWork

[GitHub] eolivelli commented on issue #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli commented on issue #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/pull/389#issuecomment-320312152 Closing, see motivations in issue -

Re: Digests are computed inside the mailWorkerPool

2017-08-04 Thread Sijie Guo
On Fri, Aug 4, 2017 at 8:50 AM, Enrico Olivelli wrote: > 2017-08-04 17:38 GMT+02:00 Sijie Guo : > > > On Aug 4, 2017 5:27 AM, "Enrico Olivelli" wrote: > > > > Hi bookkeepers, > > I noticed that digests are computed on the mailWorkerPool during addEntry > > I think that it is better to do such co

Re: Digests are computed inside the mailWorkerPool

2017-08-04 Thread Enrico Olivelli
2017-08-04 17:38 GMT+02:00 Sijie Guo : > On Aug 4, 2017 5:27 AM, "Enrico Olivelli" wrote: > > Hi bookkeepers, > I noticed that digests are computed on the mailWorkerPool during addEntry > I think that it is better to do such computation outside the pool > > > I have drafted a patch to share my co

Re: Digests are computed inside the mailWorkerPool

2017-08-04 Thread Sijie Guo
On Aug 4, 2017 5:27 AM, "Enrico Olivelli" wrote: Hi bookkeepers, I noticed that digests are computed on the mailWorkerPool during addEntry I think that it is better to do such computation outside the pool I have drafted a patch to share my code https://github.com/apache/bookkeeper/pull/389 the

[GitHub] zhaijack opened a new issue #390: Test errors in TestRackawareEnsemblePlacementPolicyUsingScript

2017-08-04 Thread git
zhaijack opened a new issue #390: Test errors in TestRackawareEnsemblePlacementPolicyUsingScript URL: https://github.com/apache/bookkeeper/issues/390 **BUG REPORT** This error not reproduced every time. 1. Please describe the issue you observed: - What did you do? r

Digests are computed inside the mailWorkerPool

2017-08-04 Thread Enrico Olivelli
Hi bookkeepers, I noticed that digests are computed on the mailWorkerPool during addEntry I think that it is better to do such computation outside the pool I have drafted a patch to share my code https://github.com/apache/bookkeeper/pull/389 the patch covers only LedgerHandleAdv as it is just a p

[GitHub] eolivelli opened a new pull request #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli opened a new pull request #389: WIP - Issue-388 Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/pull/389 Move computeDigestAndPackageForSending out of the mainWorkerPool. The mainWorkerPool threadpool is used for all

[GitHub] eolivelli opened a new issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool

2017-08-04 Thread git
eolivelli opened a new issue #388: Compute digest on caller code of addEntry and offload mainWorkerPool URL: https://github.com/apache/bookkeeper/issues/388 **FEATURE REQUEST** 1. Please describe the feature you are requesting. We are computing computeDigestAndPackageForSending in

[GitHub] eolivelli commented on issue #343: TestFencing.testManyOpenParallel

2017-08-04 Thread git
eolivelli commented on issue #343: TestFencing.testManyOpenParallel URL: https://github.com/apache/bookkeeper/issues/343#issuecomment-320215269 @zhaijack @sijie @jvrao @merlimat is this a blocker for 4.5 ? the test is flaky but I wonder if there is something we changed that introduced "

[GitHub] eolivelli commented on issue #387: Support SASL SCRAM authentication

2017-08-04 Thread git
eolivelli commented on issue #387: Support SASL SCRAM authentication URL: https://github.com/apache/bookkeeper/issues/387#issuecomment-320208683 @sijie would it be useful to create a area/security label ? This is an automate

[GitHub] eolivelli opened a new issue #387: Support SASL SCRAM authentication

2017-08-04 Thread git
eolivelli opened a new issue #387: Support SASL SCRAM authentication URL: https://github.com/apache/bookkeeper/issues/387 **FEATURE REQUEST** 1. Please describe the feature you are requesting. We are supporting only TSL and Kerberos secure authentication methods, It would be good

[GitHub] eolivelli commented on issue #386: Issue-385 Upgrade to commons-lang 2.6

2017-08-04 Thread git
eolivelli commented on issue #386: Issue-385 Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/pull/386#issuecomment-320207059 @sijie yes I forgot to add 4.6, for 4.5 it is not important This is an automat

[GitHub] sijie commented on issue #386: Issue-385 Upgrade to commons-lang 2.6

2017-08-04 Thread git
sijie commented on issue #386: Issue-385 Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/pull/386#issuecomment-320206227 marked this in 4.6.0. so it shouldn't be merged until we cut 4.5 branch. This is a

[GitHub] eolivelli commented on issue #385: Upgrade to commons-lang 2.6

2017-08-04 Thread git
eolivelli commented on issue #385: Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/issues/385#issuecomment-320199177 I am running in production commons-lang 2.6 + bookie on BK 4.4 since months without problems -

[GitHub] eolivelli opened a new pull request #386: Issue-385 Upgrade to commons-lang 2.6

2017-08-04 Thread git
eolivelli opened a new pull request #386: Issue-385 Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/pull/386 Upgrade to commons-lang 2.6 which can run on Java9 see explanation on #385 This is an auto

[GitHub] eolivelli opened a new issue #385: Upgrade to commons-lang 2.6

2017-08-04 Thread git
eolivelli opened a new issue #385: Upgrade to commons-lang 2.6 URL: https://github.com/apache/bookkeeper/issues/385 We are including commons-lang.2.4.jar in bookkeeper-server package. This version is not compatible with Java9. The Bookie runs well with commons-lang 2.6 and with Java9.

[GitHub] jiazhai closed issue #262: Useless option "explicitLacInterval" is set to 1 in default bk_server.conf file

2017-08-04 Thread git
jiazhai closed issue #262: Useless option "explicitLacInterval" is set to 1 in default bk_server.conf file URL: https://github.com/apache/bookkeeper/issues/262 This is an automated message from the Apache Git Service. To re

[GitHub] jiazhai closed pull request #375: Issue-262 Useless option explicitLacInterval is set to 1 in default bk_server.conf

2017-08-04 Thread git
jiazhai closed pull request #375: Issue-262 Useless option explicitLacInterval is set to 1 in default bk_server.conf URL: https://github.com/apache/bookkeeper/pull/375 This is an automated message from the Apache Git Servic