[GitHub] jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status

jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128908746 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status

jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128908715 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -149,6 +150,8 @

[GitHub] jvrao commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full

jvrao commented on issue #81: BOOKKEEPER-753: Bookie should run garbage collection before startup when all directories became full URL: https://github.com/apache/bookkeeper/pull/81#issuecomment-317223762 Awesome @sijie. This

Build failed in Jenkins: bookkeeper-master #1826

See -- [...truncated 35.27 KB...] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.612 sec - in org.apache.bookkeeper.client.TestSequenceRead Running org.apache.bookkee

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897626 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897596 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897498 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897491 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897479 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +

[GitHub] eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status

eribeiro commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128897464 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java #

[GitHub] eolivelli commented on issue #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest

eolivelli commented on issue #275: BOOKKEEPER-1102: Fix BookKeeeperDiskSpaceWeightedLedgerPlacementTest URL: https://github.com/apache/bookkeeper/pull/275#issuecomment-317164366 I think that this patch does more than fixing a test case. Maybe we should change the title --

[GitHub] eolivelli commented on issue #195: Update JMX documentation

eolivelli commented on issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195#issuecomment-317163046 This weekend I do not have time. I can do next week This is an automated message from the

[GitHub] sijie commented on issue #230: Add Checkstyle to the build process

sijie commented on issue #230: Add Checkstyle to the build process URL: https://github.com/apache/bookkeeper/issues/230#issuecomment-317161999 @sigee are you still working on this? shall other contributors help pick up this as well?

[GitHub] sijie commented on issue #195: Update JMX documentation

sijie commented on issue #195: Update JMX documentation URL: https://github.com/apache/bookkeeper/issues/195#issuecomment-317161950 @eolivelli are you working on this? I am cleaning up the documentation task for 4.5.0. This

[GitHub] sijie commented on issue #247: Missing JavaDoc for classes

sijie commented on issue #247: Missing JavaDoc for classes URL: https://github.com/apache/bookkeeper/issues/247#issuecomment-317161865 any volunteers? This is an automated message from the Apache Git Service. To respond to th

[GitHub] sijie commented on issue #247: Missing JavaDoc for classes

sijie commented on issue #247: Missing JavaDoc for classes URL: https://github.com/apache/bookkeeper/issues/247#issuecomment-317161850 marked this as a blocker because we can't have such TODO in javadoc for 4.5.0 This is an a

[GitHub] sijie commented on issue #266: Issue 265: Add persistable bookie status

sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-317161792 addressed the comments. This is an automated message from the Apache Git Servic

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891404 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java ##

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891280 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891319 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891266 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891351 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891390 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java ##

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891356 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java ## @@ -146

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891332 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891329 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891401 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java ##

[GitHub] sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status

sijie commented on a change in pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#discussion_r128891298 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStatus.java ## @@ -0,0 +1,2