Re: CI

Cool. Thank you Enrico. On Wed, Jul 19, 2017 at 9:53 PM, Enrico Olivelli wrote: > Il gio 20 lug 2017, 00:30 Sijie Guo ha scritto: > > > Two problems: > > > > - it seems that maven-checkstyle doesn't run well for > bookkeeper-stats-api > > module. so the CI build fails. we might need to take a l

Re: CI

Il gio 20 lug 2017, 00:30 Sijie Guo ha scritto: > Two problems: > > - it seems that maven-checkstyle doesn't run well for bookkeeper-stats-api > module. so the CI build fails. we might need to take a look into it. > I will work on it > > - it seems that -Dmaven.test.failure.ignore=true is used

Re: Bookie Http Endpoint

Il gio 20 lug 2017, 00:37 Sijie Guo ha scritto: > On Wed, Jul 19, 2017 at 10:02 AM, Dustin Castor < > dustincas...@yahoo.com.invalid> wrote: > > > I do agree that we need a contractual way of managing the server > lifecycle > > via an interface -- identical to how we do it with stat providers. >

[GitHub] sijie opened a new pull request #268: Issue 267: Bookie should serve in read only mode during shutting down.

sijie opened a new pull request #268: Issue 267: Bookie should serve in read only mode during shutting down. URL: https://github.com/apache/bookkeeper/pull/268 Descriptions of the changes in this PR: Set the bookie in readonly mode during shutting down. (contributed by @yzang)

[GitHub] sijie opened a new issue #267: Turn Bookie to read only mode during shutting down.

sijie opened a new issue #267: Turn Bookie to read only mode during shutting down. URL: https://github.com/apache/bookkeeper/issues/267 **FEATURE REQUEST** 1. Please describe the feature you are requesting. For a graceful shutdown, turn the bookie to readonly before shutting d

[GitHub] sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README

sijie commented on issue #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248#issuecomment-316568681 I tried a few methods. they didn't really work. so I am not sure if we really need to resize it. but I'd prefer having a logo in README, because people d

[GitHub] sijie commented on issue #266: Issue 265: Add persistable bookie status

sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-316567072 This feature is contributed by @yzang This is an automated message from the Apa

[GitHub] sijie opened a new pull request #266: Issue 265: Add persistable bookie status

sijie opened a new pull request #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266 Descriptions of the changes in this PR: - Add support for persisting bookie status - Add configuration to enable/disable this feature - Add test case

[GitHub] sijie opened a new issue #265: Add persistable bookie status

sijie opened a new issue #265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/issues/265 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently bookie status is transient. It is a bit hard for management tooling. This feature

[GitHub] sijie opened a new pull request #264: Issue 263: Enable request rate limiter in zookeeper client

sijie opened a new pull request #264: Issue 263: Enable request rate limiter in zookeeper client URL: https://github.com/apache/bookkeeper/pull/264 Descriptions of the changes in this PR: Eanble request rate limiter in zookeeper client. The rate limiter logic is in place, but is nev

[GitHub] sijie opened a new issue #263: Enable request rate limiter in zookeeper client

sijie opened a new issue #263: Enable request rate limiter in zookeeper client URL: https://github.com/apache/bookkeeper/issues/263 Port the request rate limiter change from Twitter branch. This is an automated message from t

Re: Bookie Http Endpoint

On Wed, Jul 19, 2017 at 10:02 AM, Dustin Castor < dustincas...@yahoo.com.invalid> wrote: > I do agree that we need a contractual way of managing the server lifecycle > via an interface -- identical to how we do it with stat providers. > Personally I don't think we can really have contracts for

[GitHub] sijie commented on issue #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs

sijie commented on issue #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs URL: https://github.com/apache/bookkeeper/pull/185#issuecomment-316538197 /cc @lucperkins This is an automated message from the Apache G

CI

Two problems: - it seems that maven-checkstyle doesn't run well for bookkeeper-stats-api module. so the CI build fails. we might need to take a look into it. - it seems that -Dmaven.test.failure.ignore=true is used for this job. this hides problems in master. so it would be good to separate 'depl

Build failed in Jenkins: bookkeeper-master #1820

See Changes: [eolivelli] ISSUE #256: [eolivelli] ISSUE #258: -- [...truncated 356.13 KB...] at net.sourceforge.cobertura.javancss.parser.JavaParser.Multiplicati

Re: Bookie Http Endpoint

I do agree that we need a contractual way of managing the server lifecycle via an interface -- identical to how we do it with stat providers. Personally I don't think we can really have contracts for each and every method we all want from an interface, so not so sure how far the interface can go

Re: BookKeeper and code-coverage - JaCoco

Hmm he should mail you the token rather then posting on the jira :) On Jul 19, 2017 8:56 AM, "Enrico Olivelli" wrote: > We have the token, it is in the ticket. > I will do some tests soon > Enrico > > Il mer 19 lug 2017, 17:52 Enrico Olivelli ha > scritto: > > > this is the INFRA ticket for hav

Re: BookKeeper and code-coverage - JaCoco

We have the token, it is in the ticket. I will do some tests soon Enrico Il mer 19 lug 2017, 17:52 Enrico Olivelli ha scritto: > this is the INFRA ticket for having a coveralls.io token in our Jenkins > builds > https://issues.apache.org/jira/browse/INFRA-14649 > > -- Enrico > > 2017-07-17 23:49

Re: BookKeeper and code-coverage - JaCoco

this is the INFRA ticket for having a coveralls.io token in our Jenkins builds https://issues.apache.org/jira/browse/INFRA-14649 -- Enrico 2017-07-17 23:49 GMT+02:00 Enrico Olivelli : > > > Il lun 17 lug 2017, 22:55 Sijie Guo ha scritto: > >> On Tue, Jul 18, 2017 at 4:46 AM, Enrico Olivelli >>

[GitHub] eolivelli commented on issue #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs

eolivelli commented on issue #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs URL: https://github.com/apache/bookkeeper/pull/185#issuecomment-316430327 @jiazhai @sijie I have finished my proposal. It is ready for review. I will start writing about BookKeeper Authenticati

[GitHub] eolivelli opened a new issue #262: Useless option "explicitLacInterval" is set to 1 in default bk_server.conf file

eolivelli opened a new issue #262: Useless option "explicitLacInterval" is set to 1 in default bk_server.conf file URL: https://github.com/apache/bookkeeper/issues/262 The default bk_server.conf reports ``` # Interval between sending an explicit LAC in seconds explicitLacInterv

[GitHub] caiok commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars

caiok commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars URL: https://github.com/apache/bookkeeper/issues/260#issuecomment-316404351 It's awesome, thanks @jiazhai Thi

[GitHub] caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316403959 @jiazhai Seems that Apache examples are a bit poor on this side. [Here an example](https://hub.docker.com/r/azul/zulu-openjdk/) (

[GitHub] jiazhai commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars

jiazhai commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars URL: https://github.com/apache/bookkeeper/issues/260#issuecomment-316380019 Based on Pulsar's script, I have already done a change satisfy our need, once PR #197 merged, I c

[GitHub] jiazhai commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars

jiazhai commented on issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars URL: https://github.com/apache/bookkeeper/issues/260#issuecomment-316380019 Based on Pulsar's script, I have already done a change satisfy our need, once PR 197 merged, I co

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316379132 Hi @caiok, Postgres example is not a "Automated Docker Build", While if bookkeeper image goes into [apache](https://hub.do

[GitHub] eolivelli commented on issue #248: BOOKKEEPER-1027: Cleanup README

eolivelli commented on issue #248: BOOKKEEPER-1027: Cleanup README URL: https://github.com/apache/bookkeeper/pull/248#issuecomment-316360392 Maybe we can just put the logo in the readme and use it as project logo in the Github project --

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128219778 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] caiok opened a new issue #261: Docker image: create a tutorial dice application docker build

caiok opened a new issue #261: Docker image: create a tutorial dice application docker build URL: https://github.com/apache/bookkeeper/issues/261 Like emerged in #197, it's could be useful to have the tutorial code under bookkeeper official repo and to have the docker build of the tutorial

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128217985 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128216700 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] caiok opened a new issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars

caiok opened a new issue #260: Docker image: provide a way to pass any desired configuration property via ENV vars URL: https://github.com/apache/bookkeeper/issues/260 In the first docker image PR (#197) emerged that could be useful to have a way to pass any desired configuration property

[GitHub] caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128213959 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# -- #

[GitHub] caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

caiok commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316344903 @jiazhai It's ok to have such a structure. We need it in order to provide docker images of older versions. Having a CentOS im

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128204685 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128205877 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# -- #

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128204795 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128206584 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128205203 ## File path: docker/4.4.0-alpine/Dockerfile ## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpi

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128206180 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caiok/

[GitHub] sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

sijie commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128205397 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# -- #

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and polish it, while using it. @caiok Still have

Re: Bookie Http Endpoint

On Wed, Jul 19, 2017 at 2:55 PM, Enrico Olivelli wrote: > 2017-07-19 3:27 GMT+02:00 Yiming Zang : > > > Hi all, > > > > We also have a working implementation in Twitter, we use Http Endpoint > > mostly for getting quorum loss information, underreplicated ledgers, > manage > > bookie status etc. >

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still h

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and do polish it, while using it. @caiok Still ha

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in as the first stage, and polish it, while using it. @caiok Still have

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still h

[GitHub] jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on issue #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#issuecomment-316331977 Generally, looks good to me. We may merge it in for the first stage, and do polish it, while using it. @caiok Still h

[GitHub] eolivelli closed pull request #259: Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed

eolivelli closed pull request #259: Issue 258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed URL: https://github.com/apache/bookkeeper/pull/259 This is an automated message from the Apache Git Service

[GitHub] eolivelli closed issue #258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed

eolivelli closed issue #258: BookieInitializationTest.testRegNodeExistsAfterSessionTimeOut failed URL: https://github.com/apache/bookkeeper/issues/258 This is an automated message from the Apache Git Service. To respond to