[GitHub] eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv

eolivelli commented on a change in pull request #244: Issue#243 - asyncAddEntry fails with NPE with LedgerHandlerAdv URL: https://github.com/apache/bookkeeper/pull/244#discussion_r127641396 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] eolivelli commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv

eolivelli commented on issue #243: asyncAddEntry fails with NPE with LedgerHandler created with createLedgerAdv URL: https://github.com/apache/bookkeeper/issues/243#issuecomment-315678972 @sijie I have modified the description, the new testcase in PR #244 demostrates the problem ---

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127622612 ## File path: docker/Makefile ## @@ -0,0 +1,180 @@ + +VERSION ?= 4.4.0-alpine +IMAGE ?= caio

Regarding the configuration in BK docker image # PR 197

Hi, Thanks a lot for @caiok 's PR for BK docker image. While in the review there was some concern related to the configuration things, and it is some kind of fundamental for docker image, it may be worth to have some discuss here to get some feedback. :). In PR 197

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127621270 ## File path: docker/4.4.0/Dockerfile ## @@ -0,0 +1,63 @@ +FROM centos:7 +MAINTAINER Apache

[GitHub] jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image

jiazhai commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127620562 ## File path: docker/4.4.0-alpine/run.sh ## @@ -0,0 +1,68 @@ +#/bin/bash + +# --

[GitHub] jiazhai commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1)

jiazhai commented on issue #231: Issue 230: Add Checkstyle to the build process (Part 1) URL: https://github.com/apache/bookkeeper/pull/231#issuecomment-315645477 @sigee Please also help handle the "TODOs" in PR #234 This i

[GitHub] jiazhai commented on issue #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA

jiazhai commented on issue #238: Issue-237 Upgrade to ZooKeeper 3.5.3-BETA URL: https://github.com/apache/bookkeeper/pull/238#issuecomment-315645301 +1, LGTM. This is an automated message from the Apache Git Service. To respo

Jenkins build is back to normal : bookkeeper-master #1817

See

[GitHub] eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

eolivelli commented on issue #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246#issuecomment-315606130 I added cobertura on after-success callback but the build failed, tests are not compiling. I will investigate

[GitHub] eolivelli opened a new pull request #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file

eolivelli opened a new pull request #246: Issue 245 Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/pull/246 Enable Coveralls.io and Cobertura during build on Travis-CI

[GitHub] eolivelli opened a new issue #245: Enable Coverall.io and Covertura on Travis configuration file

eolivelli opened a new issue #245: Enable Coverall.io and Covertura on Travis configuration file URL: https://github.com/apache/bookkeeper/issues/245 There is an automatic token exchange for open source projects between Travis and Coveralls.io. We need to run Cobertura and Coveralls.io

Re: BookKeeper and code-coverage - JaCoco

I have just committed coveralls.io and cobertura plugins into main pom.xml (as DistributedLog does) The next step is to enable cobertura and tests in Travis. Currently we do not run tests on Travis because it is very slow. any ideas ? Meanwhile I am going to submit a PR with a change in Travis

[GitHub] eolivelli closed issue #232: Add code-coverage report

eolivelli closed issue #232: Add code-coverage report URL: https://github.com/apache/bookkeeper/issues/232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] eolivelli closed pull request #233: Issue 232: Add code-coverage report

eolivelli closed pull request #233: Issue 232: Add code-coverage report URL: https://github.com/apache/bookkeeper/pull/233 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi