[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065761#comment-16065761 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 Right. So if there are two dirs /journal1 and /journal2 both were created on the same disk. With the dedup, we will choose only one say, /journal1 and /journal2 is always kept empty. Am I

Re: Write retry issues with ZooKeeperClient

Should EXPIRED be considered a recoverable error for retry purposes? Retrying in that case would mean that operations which might have been submitted under the assumption that ephemeral nodes were still present would be retried after the ephemeral nodes disappeared. Don't all users have special ha

Re: Write retry issues with ZooKeeperClient

On Tue, Jun 27, 2017 at 2:36 PM, Sam Just wrote: > On Tue, Jun 27, 2017 at 2:29 PM, Sijie Guo wrote: > > > On Tue, Jun 27, 2017 at 10:18 AM, Sam Just wrote: > > > > > JV: What do you mean by "May not be perfect for negative testing"? > > > > > > I don't think there's anything inevitable about t

Re: Write retry issues with ZooKeeperClient

On Tue, Jun 27, 2017 at 2:29 PM, Sijie Guo wrote: > On Tue, Jun 27, 2017 at 10:18 AM, Sam Just wrote: > > > JV: What do you mean by "May not be perfect for negative testing"? > > > > I don't think there's anything inevitable about this particular class of > > behavior. ZK could have chosen to a

Re: [DISCUSS] Move Bookkeeper Website from CMS to Jekyll (or other static generators)

Thank you, Enrico. I have a co-worker is helping with designing the website with Jekyll now. We will try to share with the community in a couple of days. - Sijie On Tue, Jun 27, 2017 at 12:22 PM, Enrico Olivelli wrote: > I read the wiki page and looks great. > Let's do it. > I am not sure abou

Re: Write retry issues with ZooKeeperClient

On Tue, Jun 27, 2017 at 10:18 AM, Sam Just wrote: > JV: What do you mean by "May not be perfect for negative testing"? > > I don't think there's anything inevitable about this particular class of > behavior. ZK could have chosen to avoid this problem entirely by doing > duplicate op detection se

[GitHub] bookkeeper issue #213: Issue 212: change github PR template to adjust both i...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/213 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065468#comment-16065468 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user sijie commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/189 @jvrao sorry, what is the performance problem behind this? is there anything I missed in this conversation? If a user configures multiple journal directories, can we dedup and use

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065446#comment-16065446 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user sijie commented on

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user sijie commented on the issue: https://github.com/apache/bookkeeper/pull/80 @eolivelli thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065434#comment-16065434 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user eolivelli commented

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/80 @sijie I am going to use this improvement in order to make a necessary change in order to support java9. I would like to make 4.5 runnable on java9 as we are starting to test all of our apps and

Re: [DISCUSS] Move Bookkeeper Website from CMS to Jekyll (or other static generators)

I read the wiki page and looks great. Let's do it. I am not sure about the push via gut works but I will be happy to try. If we approve this change I volunteer to do the migration if the website from subversion to git. Enrico Il gio 22 giu 2017, 05:31 Jia Zhai ha scritto: > This is great to have

[jira] [Commented] (BOOKKEEPER-1033) Handle DirsPartitionDuplication

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065218#comment-16065218 ] ASF GitHub Bot commented on BOOKKEEPER-1033: Github user jvrao commented

[GitHub] bookkeeper issue #189: BOOKKEEPER-1033: Handle DirsPartitionDuplication

Github user jvrao commented on the issue: https://github.com/apache/bookkeeper/pull/189 The flag is to allow backward compatibility and warn the user if they configured multiple journal dirs on the same partition by mistake. Per @sijie's point, yes we can handle them by monitoring the

Re: Write retry issues with ZooKeeperClient

JV: What do you mean by "May not be perfect for negative testing"? I don't think there's anything inevitable about this particular class of behavior. ZK could have chosen to avoid this problem entirely by doing duplicate op detection server-side with a per-session transaction log. Since it doesn

Re: Write retry issues with ZooKeeperClient

I agree in current callback model, we only propagate error code to the outer client, so we lose the information about the detail cause. But I think we also tried to map some zk error codes to bk error codes. NoNode -> NoLedger NodeExists -> LedgerExists ··· (other codes) Also we tried to hide zk

Re: Write retry issues with ZooKeeperClient

I agree. For create ledger, it is easy to handle - the zk ledger manager can catch such exception and recreate a new one. For create ledger adv, the ledger id is supplied by application, so the application is responsible for handle this ledgerexists exception. Thoughts? On Jun 27, 2017 6:45 AM, "

Re: Write retry issues with ZooKeeperClient

Il giorno mar, 27/06/2017 alle 13.45 +, Venkateswara Rao Jujjuri ha scritto: This is nothing different in any network based system. Like nfs. So we need to have some kind of logic on the client side to make reasonable assumption. May not be perfect for negative testing. Many times I wanted t

Re: Write retry issues with ZooKeeperClient

This is nothing different in any network based system. Like nfs. So we need to have some kind of logic on the client side to make reasonable assumption. May not be perfect for negative testing. JV On Mon, Jun 26, 2017 at 11:19 PM Sijie Guo wrote: > Hi Sam, > > Let's assume there is no such retr

Build failed in Jenkins: bookkeeper-master #1797

See -- [...truncated 1.11 MB...] Running org.apache.bookkeeper.test.LocalBookiesRegistryTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.087 sec - in org.apache.bo

[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/214 some errors from my logs: org.apache.bookkeeper.test.TestBackwardCompat-output.txt: ``` io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1 at io.n

[GitHub] bookkeeper issue #214: Fix ByteBuf refcount release

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/214 @kishorekasi with this fix on Jenkins and on my laptop the build crashes during tests. This never happens on actual master. see https://builds.apache.org/job/bookkeeper-precommit-pullre

[GitHub] bookkeeper issue #216: Remove useless and misleading '&= true'

GitHub user diegosalvi opened an issue: https://github.com/apache/bookkeeper/issues/216 Remove useless and misleading '&= true' **QUESTION** This is just a super minor issue, I stumbled upon it looking into #58... Assignments like 'shutDownTask =& true' aren't usefu

[GitHub] bookkeeper pull request #215: Issue #: Remove useless and misleading '&= tru...

GitHub user diegosalvi opened a pull request: https://github.com/apache/bookkeeper/pull/215 Issue #: Remove useless and misleading '&= true' This is just a super minor issue, I stumbled upon it looking into https://github.com/apache/bookkeeper/pull/58... Assignments like 's