Re: Question regarding synchronization in EntryLogger

Il mer 10 mag 2017, 01:59 Sijie Guo ha scritto: > On Sat, May 6, 2017 at 9:51 AM, Charan Reddy G > wrote: > > > Hey, > > > > In EntryLogger, I'm wondering what is the need of making flushCurrentLog > > method synchronized? (if we make logChannel variable volatile or of type > > AtomicReference a

Re: Issue in GarbageCollectorThread compaction logic

Looked at the source and it is fdatasync() https://android.googlesource.com/platform/libcore/+/2496a68/luni/src/main/java/java/nio/FileChannelImpl.java if (metadata) { Libcore.os.fsync(fd); } else { Libcore.os.fdatasync(fd); } So, agreed. fdatasync() fluesh metadata when the file size etc

Jenkins build is back to normal : bookkeeper-master-git-pullrequest #360

See

Build failed in Jenkins: bookkeeper-master-git-pullrequest #359

See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

Re: [DRAFT] [REPORT] BookKeeper - May 2017

Sent the report to the board. - Sijie On Wed, May 3, 2017 at 5:25 PM, Enrico Olivelli wrote: > +1 for me > > 2017-05-03 11:24 GMT+02:00 Sijie Guo : > > Discussed with JV offline. Updated the draft. Folks, please take a look > and > > give me feedback. > > > > ## Description: > > > > BookKeeper

[jira] [Resolved] (BOOKKEEPER-1053) Upgrade RAT maven version to 0.12 and ignore Eclipse project files

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1053. -- Resolution: Fixed Issue resolved by merging pull request 143 [https://g

[jira] [Commented] (BOOKKEEPER-1053) Upgrade RAT maven version to 0.12 and ignore Eclipse project files

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003876#comment-16003876 ] ASF GitHub Bot commented on BOOKKEEPER-1053: Github user asfgit closed th

[GitHub] bookkeeper pull request #143: BOOKKEEPER-1053: Upgrade RAT maven version to ...

Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: bookkeeper-master-git-pullrequest #358

See Changes: [mmerli] BOOKKEEPER-1054: Add gitignore file -- GitHub pull request #144 to apache/bookkeeper [EnvInject] - Loading node environment variables

Build failed in Jenkins: bookkeeper-master-git-pullrequest #357

See Changes: [mmerli] BOOKKEEPER-1053: Upgrade RAT maven version to 0.12 and ignore Eclipse -- [...truncated 27.95 KB...] Tests run: 4, Failures: 0, Errors

[jira] [Commented] (BOOKKEEPER-1054) Add gitignore file

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003825#comment-16003825 ] ASF GitHub Bot commented on BOOKKEEPER-1054: GitHub user merlimat opened

[jira] [Created] (BOOKKEEPER-1054) Add gitignore file

Matteo Merli created BOOKKEEPER-1054: Summary: Add gitignore file Key: BOOKKEEPER-1054 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1054 Project: Bookkeeper Issue Type: Task

[GitHub] bookkeeper pull request #144: BOOKKEEPER-1054: Add gitignore file

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/144 BOOKKEEPER-1054: Add gitignore file We should have a .gitignore file to hide all build generated files. You can merge this pull request into a Git repository by running: $ git pull https:

Build failed in Jenkins: bookkeeper-master-git-pullrequest #356

See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

[jira] [Commented] (BOOKKEEPER-1053) Upgrade RAT maven version to 0.12 and ignore Eclipse project files

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003797#comment-16003797 ] ASF GitHub Bot commented on BOOKKEEPER-1053: GitHub user merlimat opened

Re: Question regarding synchronization in EntryLogger

On Sat, May 6, 2017 at 9:51 AM, Charan Reddy G wrote: > Hey, > > In EntryLogger, I'm wondering what is the need of making flushCurrentLog > method synchronized? (if we make logChannel variable volatile or of type > AtomicReference and bytesWrittenSinceLastFlush of type AtomicLong). Anyhow > in Bu

[GitHub] bookkeeper pull request #143: BOOKKEEPER-1053: Upgrade RAT maven version to ...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/143 BOOKKEEPER-1053: Upgrade RAT maven version to 0.12 and ignore Eclipse project files You can merge this pull request into a Git repository by running: $ git pull https://github.com/merlim

[jira] [Created] (BOOKKEEPER-1053) Upgrade RAT maven version to 0.12 and ignore Eclipse project files

Matteo Merli created BOOKKEEPER-1053: Summary: Upgrade RAT maven version to 0.12 and ignore Eclipse project files Key: BOOKKEEPER-1053 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1053 Pr

Re: Issue in GarbageCollectorThread compaction logic

We don't force flush metadata in bookies. Because: - flush metadata requires more I/O operations. - flush metadata usually updates file metadata information (e.g. access permissions, last modification/access time). The difference of force(false) and force(true) is the difference between fdatasync

Build failed in Jenkins: bookkeeper-master-git-pullrequest #355

See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

Build failed in Jenkins: bookkeeper-master-git-pullrequest #354

See Changes: [mmerli] BOOKKEEPER-1008 Move to Netty4.1 [mmerli] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [mmerli] Addressing ref count issues in LedgerHandleAdv

[jira] [Commented] (BOOKKEEPER-1052) Print autorecovery enabled or not in bookie shell

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003567#comment-16003567 ] ASF GitHub Bot commented on BOOKKEEPER-1052: Github user asfgit closed th

[GitHub] bookkeeper pull request #142: BOOKKEEPER-1052: Print autorecovery enabled or...

Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (BOOKKEEPER-1052) Print autorecovery enabled or not in bookie shell

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1052. -- Resolution: Fixed Issue resolved by merging pull request 142 [https://g

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003558#comment-16003558 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user asfgit closed th

[jira] [Resolved] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Merli resolved BOOKKEEPER-1051. -- Resolution: Fixed Issue resolved by merging pull request 141 [https://g

[GitHub] bookkeeper pull request #141: BOOKKEEPER-1051: Fast shutdown for GarbageColl...

Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003532#comment-16003532 ] ASF GitHub Bot commented on BOOKKEEPER-1051: Github user merlimat comment

[GitHub] bookkeeper issue #141: BOOKKEEPER-1051: Fast shutdown for GarbageCollectorTh...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/141 Build time reduces from 2h to 30min! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

Build failed in Jenkins: bookkeeper-master-git-pullrequest #350

See Changes: [mmerli] BOOKKEEPER-1051: Fast shutdown for GarbageCollectorThread -- [...truncated 24.40 KB...] Tests run: 8, Failures: 0, Errors: 0, Skipped

[jira] [Commented] (BOOKKEEPER-1052) Print autorecovery enabled or not in bookie shell

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003487#comment-16003487 ] ASF GitHub Bot commented on BOOKKEEPER-1052: GitHub user merlimat opened

[GitHub] bookkeeper pull request #142: BOOKKEEPER-1052: Print autorecovery enabled or...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/142 BOOKKEEPER-1052: Print autorecovery enabled or not in bookie shell Print the current status of auto-recovery, whether it's enabled or disabled. You can merge this pull request into a Git repos

[jira] [Created] (BOOKKEEPER-1052) Print autorecovery enabled or not in bookie shell

Matteo Merli created BOOKKEEPER-1052: Summary: Print autorecovery enabled or not in bookie shell Key: BOOKKEEPER-1052 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1052 Project: Bookkeeper

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003478#comment-16003478 ] Matteo Merli commented on BOOKKEEPER-1050: -- {noformat} commit 61a5446b8923e5

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003473#comment-16003473 ] ASF GitHub Bot commented on BOOKKEEPER-1050: Github user asfgit closed th

[GitHub] bookkeeper pull request #140: BOOKKEEPER-1050: Cache journalFormatVersionToW...

Github user asfgit closed the pull request at: https://github.com/apache/bookkeeper/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003453#comment-16003453 ] ASF GitHub Bot commented on BOOKKEEPER-1050: Github user merlimat comment

[GitHub] bookkeeper issue #140: BOOKKEEPER-1050: Cache journalFormatVersionToWrite wh...

Github user merlimat commented on the issue: https://github.com/apache/bookkeeper/pull/140 @eolivelli Good point. This is a merge from a very old commit.. probably the alignment size was not there at the point. I'll fix that. --- If your project is set up for it, you can reply to thi

Build failed in Jenkins: bookkeeper-master-git-pullrequest #348

See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

Build failed in Jenkins: bookkeeper-master-git-pullrequest #347

See Changes: [kudayashankar] BOOKKEEPER-1008 Move to Netty4.1 [kudayashankar] Addressing review comments - Use Netty 4.1.9 - Do not include classifier [kudayashankar] Addressing ref count issue

[jira] [Commented] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003181#comment-16003181 ] ASF GitHub Bot commented on BOOKKEEPER-1051: GitHub user merlimat opened

[GitHub] bookkeeper pull request #141: BOOKKEEPER-1051: Fast shutdown for GarbageColl...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/141 BOOKKEEPER-1051: Fast shutdown for GarbageCollectorThread Several unit tests are taking very long time to complete (eg: `BookieLedgerIndexTest` taking ~10 minutes). The reason is that thes

[jira] [Created] (BOOKKEEPER-1051) Fast shutdown for GarbageCollectorThread

Matteo Merli created BOOKKEEPER-1051: Summary: Fast shutdown for GarbageCollectorThread Key: BOOKKEEPER-1051 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1051 Project: Bookkeeper

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003098#comment-16003098 ] ASF GitHub Bot commented on BOOKKEEPER-1050: GitHub user merlimat opened

[GitHub] bookkeeper pull request #140: BOOKKEEPER-1050: Cache journalFormatVersionToW...

GitHub user merlimat opened a pull request: https://github.com/apache/bookkeeper/pull/140 BOOKKEEPER-1050: Cache journalFormatVersionToWrite when starting Journal Reading the journal version format from `ServiceConfiguration` each time is inefficient. `ServiceConfiguration` is b

[jira] [Created] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

Matteo Merli created BOOKKEEPER-1050: Summary: Cache journalFormatVersionToWrite when starting Journal Key: BOOKKEEPER-1050 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1050 Project: Bookk

[jira] [Commented] (BOOKKEEPER-1010) Bump up Guava version to 20.0

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002863#comment-16002863 ] ASF GitHub Bot commented on BOOKKEEPER-1010: Github user eolivelli commen

[GitHub] bookkeeper issue #117: BOOKKEEPER-1010 Moving Guava to 20.0

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/117 @arvindkandhare ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

Build failed in Jenkins: bookkeeper-master #1742

See -- [...truncated 37.52 KB...] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec - in org.apache.bookkeeper.test.ForceReadOnlyBookieTest Running org.apache.boo

[jira] [Commented] (BOOKKEEPER-816) use native fallocate & sync_file_range to improve journal allocation

[ https://issues.apache.org/jira/browse/BOOKKEEPER-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002425#comment-16002425 ] ASF GitHub Bot commented on BOOKKEEPER-816: --- Github user eolivelli commented

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate to improve journa...

Github user eolivelli commented on the issue: https://github.com/apache/bookkeeper/pull/80 I am absolutely a newbie in linux native code, but I think this is the problem https://access.redhat.com/solutions/408503 As far as I can understand basically on RedHat based platfor

[jira] [Comment Edited] (BOOKKEEPER-1049) Run BookKeeper on Java9

[ https://issues.apache.org/jira/browse/BOOKKEEPER-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002163#comment-16002163 ] Enrico Olivelli edited comment on BOOKKEEPER-1049 at 5/9/17 6:59 AM: --