Re: Moving Hedwig to a contrib package

2015-12-02 Thread Matteo Merli
+1  I agree with Ivan Matteo On Thursday, November 26, 2015 12:53 AM, Ivan Kelly wrote: +1 I'd go even further and just remove it from the tree. There are no new contributions going into it. The hedwig src for 4.3 is pretty much the same as the hedwig src for 4.2 and for 4.4. If peo

[GitHub] bookkeeper pull request: BOOKKEEPER-855: handle session expire eve...

2015-12-02 Thread merlimat
Github user merlimat commented on the pull request: https://github.com/apache/bookkeeper/pull/1#issuecomment-161300318 Looks good to me, just the executor shutdown thing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (BOOKKEEPER-855) handle session expire event in bookie

2015-12-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035824#comment-15035824 ] ASF GitHub Bot commented on BOOKKEEPER-855: --- Github user merlimat commented

[GitHub] bookkeeper pull request: BOOKKEEPER-855: handle session expire eve...

2015-12-02 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/bookkeeper/pull/1#discussion_r46415317 --- Diff: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java --- @@ -142,7 +145,11 @@ final protected String zkBookieRegPath

[jira] [Commented] (BOOKKEEPER-855) handle session expire event in bookie

2015-12-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035814#comment-15035814 ] ASF GitHub Bot commented on BOOKKEEPER-855: --- Github user merlimat commented

Build failed in Jenkins: bookkeeper-master #1213

2015-12-02 Thread Apache Jenkins Server
See -- [...truncated 717 lines...] [INFO] [INFO] <<< findbugs-maven-plugin:2.5.2:check (default-cli) @ bookkeeper-stats-api <<< [INFO] [INFO] --- findbugs-maven-plugin:2.5.2:check (default-cli) @ bo

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

2015-12-02 Thread Jiannan Wang (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035599#comment-15035599 ] Jiannan Wang commented on BOOKKEEPER-877: - That's quite a detailed document! I

[jira] [Commented] (BOOKKEEPER-855) handle session expire event in bookie

2015-12-02 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035447#comment-15035447 ] Sijie Guo commented on BOOKKEEPER-855: -- ping. could anyone review this? [~fpj] [~

[jira] [Commented] (BOOKKEEPER-877) Script for generating patch for reviews

2015-12-02 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035443#comment-15035443 ] Sijie Guo commented on BOOKKEEPER-877: -- [~jiannan] I've documented this in the h