[Peer Review] Pull Request Eliminate Finalize in Read

2023-01-27 Thread Dejan Spasic
Hello team, I posted a pull request[0] some time ago where I (we) need your support. In general, it is about the elimination of the finalize methods or the replacement of the finalize methods[1]. I am looking forward to your advice. Have a nice one! [0] https://github.com/apache/beam/pull/24841

Beam High Priority Issue Report (44)

2023-01-27 Thread beamactions
This is your daily summary of Beam's current high priority issues that may need attention. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities. Unassigned P1 Issues: https://github.com/apache/beam/issues/25189 [Failing Test]: Pyt

Re: Beam SQL Alias issue while using With Clause

2023-01-27 Thread Talat Uyarer via dev
Hi Andrew, Yes This aligned also with my debugging. In My Kenn's reply you can see a sql test which I wrote in Calcite. Somehow Calcite does not have this issue with the 1.28 version. !use post !set outputformat mysql #Test aliases with with clause WITH tempTable(id, v) AS (select "hr"."emps"."e

Re: Beam SQL Alias issue while using With Clause

2023-01-27 Thread Andrew Pilloud via dev
Hi Talat, I did get your test case running and added some logging to RexProgramBuilder.mergePrograms. There is only one merge that occurs during the test and it has an output type of RecordType(JavaType(int) ID, JavaType(class java.lang.String) V). This does seem like the correct output name but i

Re: Beam SQL Alias issue while using With Clause

2023-01-27 Thread Andrew Pilloud via dev
Also this is at very least a Beam bug. You can file a Beam issue if you want, otherwise I will when I get back. Andrew On Fri, Jan 27, 2023 at 11:27 AM Andrew Pilloud wrote: > Hi Talat, > > I did get your test case running and added some logging to > RexProgramBuilder.mergePrograms. There is on