Re: Best way to expose windowing information in Beam YAML

2025-02-21 Thread Kenneth Knowles
+1 to option 1 On Fri, Feb 21, 2025 at 11:06 AM XQ Hu via dev wrote: > +1 to ExtractWindowingInfo > > On Fri, Feb 21, 2025 at 10:55 AM Danny McCormick via dev < > dev@beam.apache.org> wrote: > >> +1 to `ReifyWindowingInfo` (or maybe `ExtractWindowingInfo` or >> `GetWindowing` is a little more

Re: Best way to expose windowing information in Beam YAML

2025-02-21 Thread Robert Bradshaw via dev
https://github.com/apache/beam/pull/34051 ready for comments. On Fri, Feb 21, 2025 at 12:59 PM Robert Bradshaw wrote: > Sounds like consensus. (I do think option 2 might be useful for other > contextful params, but that can be deferred.) > > I'll put together a PR. > > On Fri, Feb 21, 2025 at 11

Re: Best way to expose windowing information in Beam YAML

2025-02-21 Thread Robert Bradshaw via dev
Sounds like consensus. (I do think option 2 might be useful for other contextful params, but that can be deferred.) I'll put together a PR. On Fri, Feb 21, 2025 at 11:41 AM Kenneth Knowles wrote: > +1 to option 1 > > > > On Fri, Feb 21, 2025 at 11:06 AM XQ Hu via dev > wrote: > >> +1 to Extrac

Re: Best way to expose windowing information in Beam YAML

2025-02-21 Thread XQ Hu via dev
+1 to ExtractWindowingInfo On Fri, Feb 21, 2025 at 10:55 AM Danny McCormick via dev < dev@beam.apache.org> wrote: > +1 to `ReifyWindowingInfo` (or maybe `ExtractWindowingInfo` or > `GetWindowing` is a little more understandable to the average user). I > definitely prefer something which doesn't r

Re: Best way to expose windowing information in Beam YAML

2025-02-21 Thread Danny McCormick via dev
+1 to `ReifyWindowingInfo` (or maybe `ExtractWindowingInfo` or `GetWindowing` is a little more understandable to the average user). I definitely prefer something which doesn't require extending the set of concepts/advanced usages we're exposing through Yaml, especially for a feature that I think wi