Re: [VOTE] Release 2.46.0, release candidate #1

2023-04-28 Thread Reuven Lax via dev
Those particular errors are often expected in the sink due to the protocol used. If a work item retries before committing (which could happen for many reasons including worker crashes), it will experience those errors. On Fri, Apr 28, 2023 at 12:55 PM Ahmed Abualsaud wrote: > @Danny McCormick @

Re: [VOTE] Release 2.46.0, release candidate #1

2023-04-28 Thread Ahmed Abualsaud via dev
@Danny McCormick @Reuven Lax sorry it's been a while since you looked into this, but do you remember if the fix in #25642 issue is related to the recent "ALREADY_EXISTS: The offset is within stream, expected offset..." errors? On Fri, Mar 10, 2023 at 7

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-10 Thread Ahmet Altay via dev
Thank you! Is there a tracking issue for this known issue? And would the known issues section of the release notes link to that? On Fri, Mar 10, 2023 at 11:38 AM Danny McCormick via dev < dev@beam.apache.org> wrote: > We determined that the same issue exists in the 2.45 release, so we are > goi

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-10 Thread Danny McCormick via dev
We determined that the same issue exists in the 2.45 release, so we are going to continue finalizing the release candidate. Thank you for your patience. Thanks, Danny On Wed, Mar 8, 2023 at 3:15 PM Reuven Lax wrote: > We are trying to reproduce and debug the issue we saw to validate whether > i

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Reuven Lax via dev
We are trying to reproduce and debug the issue we saw to validate whether it was a real regression or not. Will update when we know more. On Wed, Mar 8, 2023 at 11:31 AM Danny McCormick wrote: > > @Reuven Lax found a new potential regression in > BigQuery I/O, so I have paused the release rollo

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Danny McCormick via dev
@Reuven Lax found a new potential regression in BigQuery I/O, so I have paused the release rollout. I had already pushed the Python artifacts and Go tags, but not the Java ones. We have since temporarily yanked the Python release and deleted the Go tags, they were l

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-08 Thread Jan Lukavský
+1 (binding) Tested Java SDK with Flink and Spark 3 runner. Thanks,  Jan On 3/8/23 01:53, Valentyn Tymofieiev via dev wrote: +1. Verified the composition of Python containers and ran Python pipelines on Dataflow runner v1 and runner v2. On Tue, Mar 7, 2023 at 4:11 PM Ritesh Ghorse via dev

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-07 Thread Valentyn Tymofieiev via dev
+1. Verified the composition of Python containers and ran Python pipelines on Dataflow runner v1 and runner v2. On Tue, Mar 7, 2023 at 4:11 PM Ritesh Ghorse via dev wrote: > +1 (non-binding) > Validated Go SDK quickstart on direct and dataflow runner > > On Tue, Mar 7, 2023 at 10:54 AM Alexey Ro

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-07 Thread Ritesh Ghorse via dev
+1 (non-binding) Validated Go SDK quickstart on direct and dataflow runner On Tue, Mar 7, 2023 at 10:54 AM Alexey Romanenko wrote: > +1 (binding) > > Tested with https://github.com/Talend/beam-samples/ > (Java SDK v8/v11/v17, Spark 3.x runner). > > --- > Alexey > > On 7 Mar 2023, at 07:38, Ahme

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-07 Thread Alexey Romanenko
+1 (binding) Tested with https://github.com/Talend/beam-samples/ (Java SDK v8/v11/v17, Spark 3.x runner). --- Alexey > On 7 Mar 2023, at 07:38, Ahmet Altay via dev wrote: > > +1 (binding) - I validated python quickstarts on direct & dataflow runners. > > Thank you for doing the release! >

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-06 Thread Ahmet Altay via dev
+1 (binding) - I validated python quickstarts on direct & dataflow runners. Thank you for doing the release! On Sat, Mar 4, 2023 at 8:01 AM Chamikara Jayalath via dev < dev@beam.apache.org> wrote: > +1 (binding) > > Validated multi-language Java and Python pipelines. > > On Fri, Mar 3, 2023 at 1

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-04 Thread Chamikara Jayalath via dev
+1 (binding) Validated multi-language Java and Python pipelines. On Fri, Mar 3, 2023 at 1:59 PM Danny McCormick via dev wrote: > > I have encountered a failure in a Python pipeline running with Runner > v1: > > > RuntimeError: Beam SDK base version 2.46.0 does not match Dataflow > Python worker

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
> I have encountered a failure in a Python pipeline running with Runner v1: > RuntimeError: Beam SDK base version 2.46.0 does not match Dataflow Python worker version 2.45.0. Please check Dataflow worker startup logs and make sure that correct version of Beam SDK is installed. > We should underst

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
Hey Reuven, could you provide some more context on the bug/why it is important? Does it meet the standard in https://beam.apache.org/contribute/release-guide/#7-triage-release-blocking-issues-in-github ? The release branch was cut last Wednesday, so that is why it is not included. On Fri, Mar 3,

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Reuven Lax via dev
If possible, I would like to see if we could include https://github.com/apache/beam/pull/25642 as we believe this bug has been impacting multiple users. This was merged 4 days ago, but this RC cut does not seem to include it. On Fri, Mar 3, 2023 at 12:18 PM Valentyn Tymofieiev via dev < dev@beam.a

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Valentyn Tymofieiev via dev
I have encountered a failure in a Python pipeline running with Runner v1: RuntimeError: Beam SDK base version 2.46.0 does not match Dataflow Python worker version 2.45.0. Please check Dataflow worker startup logs and make sure that correct version of Beam SDK is installed. We should understand wh

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
+1 (binding). I verified that the artifacts and signatures all look good, all the containers are pushed, and tested some pipelines with a fresh install from one of the Python wheels. On Fri, Mar 3, 2023 at 11:13 AM Danny McCormick wrote: > > > The released artifacts seem to be missing the last c

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
> The released artifacts seem to be missing the last commit at > https://github.com/apache/beam/commit/c528eab18b32342daed53b750fe330d30c7e5224 > . Is this essential to the release, or just useful for validating it? It's strictly a test infrastructure change, it has no functional impact. For conte

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
The released artifacts seem to be missing the last commit at https://github.com/apache/beam/commit/c528eab18b32342daed53b750fe330d30c7e5224 . Is this essential to the release, or just useful for validating it? On Fri, Mar 3, 2023 at 11:02 AM Danny McCormick wrote: > > Thanks for calling that out,

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Danny McCormick via dev
Thanks for calling that out, and thanks for helping me fix it! We should be all set now On Fri, Mar 3, 2023 at 1:38 PM Robert Bradshaw wrote: > It appears your public key is not published in > https://dist.apache.org/repos/dist/release/beam/KEYS . > > On Fri, Mar 3, 2023 at 8:33 AM Anand Inguva

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Robert Bradshaw via dev
It appears your public key is not published in https://dist.apache.org/repos/dist/release/beam/KEYS . On Fri, Mar 3, 2023 at 8:33 AM Anand Inguva via dev wrote: > > +1 (non-binding) > Tested python wordcount quick start > https://beam.apache.org/get-started/quickstart-py/ on Direct Runner and >

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Anand Inguva via dev
+1 (non-binding) Tested python wordcount quick start https://beam.apache.org/get-started/quickstart-py/ on Direct Runner and Dataflow Runner. Thanks! On Fri, Mar 3, 2023 at 11:21 AM Bruno Volpato via dev wrote: > +1 (non-binding) > > Tested with https://github.com/GoogleCloudPlatform/DataflowTe

Re: [VOTE] Release 2.46.0, release candidate #1

2023-03-03 Thread Bruno Volpato via dev
+1 (non-binding) Tested with https://github.com/GoogleCloudPlatform/DataflowTemplates (Java SDK 11, Dataflow runner). Thanks Danny! On Thu, Mar 2, 2023 at 5:16 PM Danny McCormick via dev wrote: > Hi everyone, > Please review and vote on release candidate #1 for the version 2.46.0, as > follow