Re: [RFC] Bootloader Buffered Logging

2023-08-17 Thread Kerry Donny-Clark via dev
Much appreciated, reviewing the doc now. On Wed, Aug 16, 2023 at 9:08 PM Valentyn Tymofieiev via dev < dev@beam.apache.org> wrote: > Thanks, Jack! left some comments, looking forward to this work! > > On Wed, Aug 16, 2023 at 10:31 AM Robert Burke wrote: > >> I've added some comments but generall

Re: [RFC] Bootloader Buffered Logging

2023-08-16 Thread Valentyn Tymofieiev via dev
Thanks, Jack! left some comments, looking forward to this work! On Wed, Aug 16, 2023 at 10:31 AM Robert Burke wrote: > I've added some comments but generally +1 on this. > > A later change might be able to build from this to ensure the various > STDErr and STDOut logs from the SDK harness execut

Re: [RFC] Bootloader Buffered Logging

2023-08-16 Thread Robert Burke
I've added some comments but generally +1 on this. A later change might be able to build from this to ensure the various STDErr and STDOut logs from the SDK harness executions are always plumbed as described. But that would take more thought since other incidental logs from the users worker binar