Re: Java pre/post commit test suite breakage

I think Ken meant to say Guava 20 but the point is still valid. On Thu, Oct 26, 2017 at 8:02 PM, Kenneth Knowles wrote: > On Thu, Oct 26, 2017 at 9:14 AM, Kenneth Knowles wrote: > > > On Wed, Oct 25, 2017 at 6:51 PM, Robert Bradshaw < > > rober...@google.com.invalid> wrote: > >> > >> These are

Re: Java pre/post commit test suite breakage

On Thu, Oct 26, 2017 at 9:14 AM, Kenneth Knowles wrote: > On Wed, Oct 25, 2017 at 6:51 PM, Robert Bradshaw < > rober...@google.com.invalid> wrote: >> >> These are just some ideas; I honestly don't know. I think my upper limit >> for default precommit feedback is probably 30 minutes, and even ther

Re: Java pre/post commit test suite breakage

On Wed, Oct 25, 2017 at 6:51 PM, Robert Bradshaw < rober...@google.com.invalid> wrote: > > These are just some ideas; I honestly don't know. I think my upper limit > for default precommit feedback is probably 30 minutes, and even there I am > not very happy. > > > We should be able to get a good si

Re: Java pre/post commit test suite breakage

On Oct 25, 2017 1:04 PM, "Kenneth Knowles" wrote: Hi all, I wanted to circle back on this. We've had continual quasi-outages, where Jenkins occasionally schedules jobs but not reliably. Meanwhile, many of our most important jobs continued to hit their timeouts when they did get scheduled. On top

Re: Java pre/post commit test suite breakage

On Wed, Oct 25, 2017 at 3:59 PM, Lukasz Cwik wrote: > Another suggestion would be to break apart the project into multiple maven > projects which are released on independent schedules. > I think at some point this makes a lot of sense. Libraries of transforms built against a stable SDK like Java

Re: Java pre/post commit test suite breakage

Another suggestion would be to break apart the project into multiple maven projects which are released on independent schedules. Does anyone have any data points for what has worked for other open source communities in the past? I only have anecdotal evidence that Apache Ant+Ivy has worked well as

Re: Java pre/post commit test suite breakage

Hi all, I wanted to circle back on this. We've had continual quasi-outages, where Jenkins occasionally schedules jobs but not reliably. Meanwhile, many of our most important jobs continued to hit their timeouts when they did get scheduled. On top of that, I've run the wrong command once before mer

Re: Java pre/post commit test suite breakage

I want to wait and get some green from Jenkins running against the HEAD groovy scripts to confirm. I haven't sat at my desk long enough to see a full `mvn -P release clean verify` yet. On Mon, Oct 23, 2017 at 3:27 PM, Kenneth Knowles wrote: > I was easily able to reproduce all the sorts of failu

Re: Java pre/post commit test suite breakage

I was easily able to reproduce all the sorts of failures (and some more!) Here are some things that now work that didn't work, or didn't work correctly, before - mvn apache-rat:check - mvn -P release apache-rat:check - mvn -P release -f somewhere/else/pom.xml apache-rat:check It turns out we

Re: Java pre/post commit test suite breakage

Thanks a lot! Kenn, Were you able to reproduce RAT failures and test the fix locally? I think "mvn clean verify -Prelease" still passes for me. Timeout for the test suite has been increased in https://github.com/apache/ beam/pull/4028. On Mon, Oct 23, 2017 at 2:10 PM, Kenneth Knowles wrote: >

Re: Java pre/post commit test suite breakage

Wrong link - https://github.com/apache/beam/pull/4027 On Mon, Oct 23, 2017 at 2:10 PM, Kenneth Knowles wrote: > Yea, root cause is the config bug I described. Proposed fix at > https://github.com/apache/beam/pull/4019/files. I'm working with infra to > sort out other build issues that are probab

Re: Java pre/post commit test suite breakage

Yea, root cause is the config bug I described. Proposed fix at https://github.com/apache/beam/pull/4019/files. I'm working with infra to sort out other build issues that are probably not related. On Mon, Oct 23, 2017 at 1:53 PM, Lukasz Cwik wrote: > The build breakage I outlined is being tracked

Re: Java pre/post commit test suite breakage

The build breakage I outlined is being tracked in https://issues.apache.org/jira/browse/BEAM-3092 On Mon, Oct 23, 2017 at 11:54 AM, Lukasz Cwik wrote: > Another breaking change was caused by https://github.com/apache/ > beam/commit/241d3cedd5a8fd3f360b8ec2f3a8ef5001cbca98 because it changed > th

Re: Java pre/post commit test suite breakage

Another breaking change was caused by https://github.com/apache/beam/commit/241d3cedd5a8fd3f360b8ec2f3a8ef5001cbca98 because it changed the build layout on the Jenkins server and our RAT rules expected to apply from a root directory. I pinged Kenneth Knowles about it and he said he was taking a loo

Re: Java pre/post commit test suite breakage

Regd (1) : [4] did have have a file without Apache Licence. It was fixed the next day ( commit ), thanks to Ken Knowles who pinged me about it. On Mon, Oct 23, 2017 at 11:45 AM, V

Re: Java pre/post commit test suite breakage

I believe license errors are detected by Apache RAT, which are part of the release profile. I believe you need to run "mvn clean verify -Prelease" to enable anything associated with that profile. On Mon, Oct 23, 2017 at 11:46 AM Valentyn Tymofieiev wrote: > Hi Beam-Dev, > > It's been >5 days sin

Re: Java pre/post commit test suite breakage

Agreed. We have to have green to make progress. The timeout should be there only to halt a build that is a true failure. It looks like the RAT check is rooted in the current working directory rather than relative to the pom.xml. That's either our bug or RAT's, since it makes no sense as a default

Java pre/post commit test suite breakage

Hi Beam-Dev, It's been >5 days since the last successful run of a beam_PreCommit_Java_MavenInstall build[1] and >4 days since last successful run of beam_PreCommit_Java_MavenInstall[2]. Looking at build logs I see following problems. 1. After October 17, postcommit builds started to fail with