Re: Enabling ErrorProne analysis on sdks-java-core

2018-05-12 Thread Kenneth Knowles
I think it would be awesome to have a "-Werror" hackathon to get this turned on globally. This is a great way to protect the long-term health of the codebase at a fine granularity. Basically, the sorts of things that if you comment on them in a PR the author might think you are being annoying, so y

Enabling ErrorProne analysis on sdks-java-core

2018-05-11 Thread Scott Wegner
I just wanted to give a heads-up on pr/5319 [1], which makes sdks-java-core ErrorProne-clean and upgrades ErrorProne analysis to produce build errors. ErrorProne [2] is another static analysis tool which hooks into the Java compilation process. Kenn added it as warnings during the Gradle migration