Re: BiqQueryIO.write and Wait.on

2018-09-18 Thread Reuven Lax
I've been looking at this a bit, and I think it will be tricky to figure out how to get this working with BigQueryIO. The base problem is that Wait tries to sequence things by window, as it's hard to come up with a different definition of sequencing with unbounded inputs. However BigQueryIO rewindo

Re: BiqQueryIO.write and Wait.on

2018-07-25 Thread Carlos Alonso
Just opened this PR: https://github.com/apache/beam/pull/6055 to get feedback ASAP. Basically what it does is return the job status in a PCollection of BigQueryWriteResult objects On Fri, Jul 20, 2018 at 11:57 PM Reuven Lax wrote: > There already is a org.apache.beam.sdk.io.gcp.bigquery.WriteRes

Re: BiqQueryIO.write and Wait.on

2018-07-20 Thread Reuven Lax
There already is a org.apache.beam.sdk.io.gcp.bigquery.WriteResult class. On Tue, Jul 17, 2018 at 9:44 AM Eugene Kirpichov wrote: > Hmm, I think this approach has some complications: > - Using JobStatus makes it tied to using BigQuery batch load jobs, but the > return type ought to be the same r

Re: BiqQueryIO.write and Wait.on

2018-07-17 Thread Eugene Kirpichov
Hmm, I think this approach has some complications: - Using JobStatus makes it tied to using BigQuery batch load jobs, but the return type ought to be the same regardless of which method of writing is used (including potential future BigQuery APIs - they are evolving), or how many BigQuery load jobs

Re: BiqQueryIO.write and Wait.on

2018-07-17 Thread Carlos Alonso
All good so far. I've been a bit side tracked but more or less I have the idea of using the JobStatus as part of the collection so that not only the completion is signaled, but also the result (success/failure) can be accessed, how does it sound? Regards On Tue, Jul 17, 2018 at 3:07 AM Eugene Kir

Re: BiqQueryIO.write and Wait.on

2018-07-16 Thread Eugene Kirpichov
Hi Carlos, Any updates / roadblocks you hit? On Tue, Jul 3, 2018 at 7:13 AM Eugene Kirpichov wrote: > Awesome!! Thanks for the heads up, very exciting, this is going to make a > lot of people happy :) > > On Tue, Jul 3, 2018, 3:40 AM Carlos Alonso wrote: > >> + dev@beam.apache.org >> >> Just a

Re: BiqQueryIO.write and Wait.on

2018-07-05 Thread Chaim Turkel
yes, i must say i have been waiting for this for over 6 months, it would help a lot chaim On Tue, Jul 3, 2018 at 5:14 PM Eugene Kirpichov wrote: > > Awesome!! Thanks for the heads up, very exciting, this is going to make a lot > of people happy :) > > On Tue, Jul 3, 2018, 3:40 AM Carlos Alonso w

Re: BiqQueryIO.write and Wait.on

2018-07-03 Thread Eugene Kirpichov
Awesome!! Thanks for the heads up, very exciting, this is going to make a lot of people happy :) On Tue, Jul 3, 2018, 3:40 AM Carlos Alonso wrote: > + dev@beam.apache.org > > Just a quick email to let you know that I'm starting developing this. > > On Fri, Apr 20, 2018 at 10:30 PM Eugene Kirpich

Re: BiqQueryIO.write and Wait.on

2018-07-03 Thread Carlos Alonso
+ dev@beam.apache.org Just a quick email to let you know that I'm starting developing this. On Fri, Apr 20, 2018 at 10:30 PM Eugene Kirpichov wrote: > Hi Carlos, > > Thank you for expressing interest in taking this on! Let me give you a few > pointers to start, and I'll be happy to help everywh