Re: [VOTE] Vendored Grpc Dependency Release

2025-01-24 Thread Danny McCormick via dev
Thanks everyone for validating and voting. There are 4 approving votes, 3 of which are binding: - Danny McCormick (binding) - Yi Hu - Kenneth Knowles (binding) - Chamikara Jayalath (binding) There are no disapproving votes, and I will now finalize the release. Thanks, Danny On Thu, Jan 23,

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-23 Thread Chamikara Jayalath via dev
+1 Thanks, Cham On Thu, Jan 23, 2025 at 10:31 AM Kenneth Knowles wrote: > +1 (binding) > > On Thu, Jan 23, 2025 at 11:50 AM Danny McCormick via dev < > dev@beam.apache.org> wrote: > >> Hey folks, could I get some help validating/voting on this release? >> >> On Wed, Jan 15, 2025 at 10:44 PM Yi

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-23 Thread Kenneth Knowles
+1 (binding) On Thu, Jan 23, 2025 at 11:50 AM Danny McCormick via dev < dev@beam.apache.org> wrote: > Hey folks, could I get some help validating/voting on this release? > > On Wed, Jan 15, 2025 at 10:44 PM Yi Hu via dev > wrote: > >> +1 (non-binding) >> >> On Mon, Jan 13, 2025 at 3:56 PM Danny

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-23 Thread Danny McCormick via dev
Hey folks, could I get some help validating/voting on this release? On Wed, Jan 15, 2025 at 10:44 PM Yi Hu via dev wrote: > +1 (non-binding) > > On Mon, Jan 13, 2025 at 3:56 PM Danny McCormick > wrote: > >> Thanks, that is a good catch - it should now be up to date with the >> following updates

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-15 Thread Yi Hu via dev
+1 (non-binding) On Mon, Jan 13, 2025 at 3:56 PM Danny McCormick wrote: > Thanks, that is a good catch - it should now be up to date with the > following updates: > > Maven central repository is now > https://repository.apache.org/content/repositories/orgapachebeam-1397/ > > Commit hash is now >

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-13 Thread Danny McCormick via dev
Thanks, that is a good catch - it should now be up to date with the following updates: Maven central repository is now https://repository.apache.org/content/repositories/orgapachebeam-1397/ Commit hash is now https://github.com/apache/beam/commit/2d779f01cc89050bc192495a59b3ea9b89c98e78 Thanks,

Re: [VOTE] Vendored Grpc Dependency Release

2025-01-13 Thread Yi Hu via dev
Thanks for conducting the release I see the staged source has version number grpc-1_69_0/0.1, but the staged jars have version number beam-vendor-grpc-1_69_0/0.3. Maybe there is something missing. Need to change https://github.com/apache/beam/blob/b82bde87572b5e2b8f5cebe09aec6373de22b818/vendor/gr

[VOTE] Vendored Grpc Dependency Release

2025-01-13 Thread Danny McCormick via dev
Hi everyone! I've been working on the release of Beam's vendored grpc artifact, following the process [6]: Please review and vote on the release candidate #1 for the version 1.2.3, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The co