+1
On Mon, 4 Jun 2018 at 12:30, Robert Burke wrote:
> +1
>
> On Mon, Jun 4, 2018, 9:01 AM Raghu Angadi wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load for
>>> Code Reviews"[1], this is a vote to cha
+1
On Mon, Jun 4, 2018, 9:01 AM Raghu Angadi wrote:
> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load for Code
>> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
>> require that
>>
>> (1) At
+1
On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
> As we seem to largely have consensus in "Reducing Committer Load for Code
> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
> require that
>
> (1) At least one committer is involved with the code review, as either a
+1
I think it's already pretty close to what we do, so, no brainer ;)
Regards
JB
On 01/06/2018 19:25, Thomas Groh wrote:
> As we seem to largely have consensus in "Reducing Committer Load for
> Code Reviews"[1], this is a vote to change the Beam policy on Code
> Reviews to require that
>
> (1)
+1
On Mon, Jun 4, 2018 at 11:40 AM Łukasz Gajowy
wrote:
> +1
>
> 2018-06-04 9:12 GMT+02:00 Etienne Chauchot :
>
>> +1
>> As I was already applying this.
>>
>> Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
>>
>> +1
>>
>> I believe only some committers were aware of the old policy, an
+1
2018-06-04 9:12 GMT+02:00 Etienne Chauchot :
> +1
> As I was already applying this.
>
> Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
>
> +1
>
> I believe only some committers were aware of the old policy, and others
> were effectively doing this anyway.
>
> On Sat, Jun 2, 2018 at
+1As I was already applying this.
Le samedi 02 juin 2018 à 11:24 +0300, Reuven Lax a écrit :
> +1
>
> I believe only some committers were aware of the old policy, and others were
> effectively doing this anyway.
>
> On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner wrote:
> > +1
> >
> > On Fri, Jun
+1
I believe only some committers were aware of the old policy, and others
were effectively doing this anyway.
On Sat, Jun 2, 2018 at 2:51 AM Scott Wegner wrote:
> +1
>
> On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada wrote:
>
>> +1 :) glad that we had this discussion
>>
>> On Fri, Jun 1, 2018,
+1
On Fri, Jun 1, 2018 at 3:44 PM Pablo Estrada wrote:
> +1 :) glad that we had this discussion
>
> On Fri, Jun 1, 2018, 3:38 PM Udi Meiri wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud
>> wrote:
>>
>>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
+1 :) glad that we had this discussion
On Fri, Jun 1, 2018, 3:38 PM Udi Meiri wrote:
> +1
>
> On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud wrote:
>
>> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
>> having enough committers.
>>
>> On Fri, Jun 1, 2018 at 1:18 PM Hennin
+1
On Fri, Jun 1, 2018 at 1:46 PM Andrew Pilloud wrote:
> +1 - I hope this doesn't reduce the urgency to fix the root cause: not
> having enough committers.
>
> On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin wrote:
>>
>>> +1 -- th
+1 - I hope this doesn't reduce the urgency to fix the root cause: not
having enough committers.
On Fri, Jun 1, 2018 at 1:18 PM Henning Rohde wrote:
> +1
>
> On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin wrote:
>
>> +1 -- this is encoding what I previously thought the process was and
>> what, in
+1
On Fri, Jun 1, 2018 at 12:27 PM Dan Halperin wrote:
> +1 -- this is encoding what I previously thought the process was and what,
> in practice, I think was often the behavior of committers anyway.
>
> On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 12:1
+1 -- this is encoding what I previously thought the process was and what,
in practice, I think was often the behavior of committers anyway.
On Fri, Jun 1, 2018 at 12:21 PM, Yifan Zou wrote:
> +1
>
> On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 1
+1
On Fri, Jun 1, 2018 at 12:10 PM Robert Bradshaw wrote:
> +1
>
> On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath
> wrote:
>
>> +1
>>
>> Thanks,
>> Cham
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka wrote:
>>>
>
+1
On Fri, Jun 1, 2018 at 12:06 PM Chamikara Jayalath
wrote:
> +1
>
> Thanks,
> Cham
>
> On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen wrote:
>>>
+1
>>
+1
Thanks,
Cham
On Fri, Jun 1, 2018 at 11:36 AM Jason Kuster wrote:
> +1
>
> On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev
>>> wrote:
>>>
+1
+1
On Fri, Jun 1, 2018 at 11:28 AM Charles Chen wrote:
> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles wrote:
>>>
+1
On Fri
+1
On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka wrote:
> +1
>
> On Fri, Jun 1, 2018 at 11:28 AM Charles Chen wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev
>> wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay wrote:
>>>
+1
On Fri, J
+1. This will allow non-committers to be actively involved in code reviews
and reduce committer load.
On Fri, Jun 1, 2018 at 11:28 AM Charles Chen wrote:
> +1
>
> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev
> wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay wrote:
>>
>
+1
On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev
wrote:
> +1
>
> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles wrote:
>>
>>> +1
>>>
>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
>>>
As we seem to largely
+1
On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay wrote:
> +1
>
> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles wrote:
>
>> +1
>>
>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
>>
>>> As we seem to largely have consensus in "Reducing Committer Load for
>>> Code Reviews"[1], this is a v
+1
On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles wrote:
> +1
>
> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
>
>> As we seem to largely have consensus in "Reducing Committer Load for Code
>> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
>> require that
>>
>>
+1
On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh wrote:
> As we seem to largely have consensus in "Reducing Committer Load for Code
> Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
> require that
>
> (1) At least one committer is involved with the code review, as either a
As we seem to largely have consensus in "Reducing Committer Load for Code
Reviews"[1], this is a vote to change the Beam policy on Code Reviews to
require that
(1) At least one committer is involved with the code review, as either a
reviewer or as the author
(2) A contributor has approved the chan
25 matches
Mail list logo
