Re: [Discuss] Get rid of OWNERS files

2023-08-11 Thread Danny McCormick via dev
I think we have consensus here, so I put up https://github.com/apache/beam/pull/27896 Thanks, Danny On Thu, Aug 10, 2023 at 6:31 PM Robert Bradshaw wrote: > On Tue, Aug 8, 2023 at 9:50 AM Robert Burke wrote: > > > > Either we keep OWNERS and have the review bot use them, or we remove > them an

Re: [Discuss] Get rid of OWNERS files

2023-08-10 Thread Robert Bradshaw via dev
On Tue, Aug 8, 2023 at 9:50 AM Robert Burke wrote: > > Either we keep OWNERS and have the review bot use them, or we remove them and > use the reviews bot config as the single source of truth. +1. And I don't see any reason we're going to be any better at keeping them up to date than we have in

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread Danny McCormick via dev
> I’m generally agree with this (initially that was a good intention imho) but what could be an alternative for this? Review bot also may assign reviewers that are no longer active on the project. I propose that the reviewer bot be the full replacement, and I agree with Robert's comments about it

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread Robert Burke
Either we keep OWNERS and have the review bot use them, or we remove them and use the reviews bot config as the single source of truth. The bot is less likely to go out of date since it's at least active in how it behaves. I agree it doesn't necessarily solve the problem of things getting out of d

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread Alexey Romanenko
I’m generally agree with this (initially that was a good intention imho) but what could be an alternative for this? Review bot also may assign reviewers that are no longer active on the project. — Alexey > On 8 Aug 2023, at 16:55, Danny McCormick via dev wrote: > > Hey everyone, I'd like to

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread Kerry Donny-Clark via dev
Thanks Danny! I agree. OWNERS causes unnecessary friction, and doesn't provide value. Kerry On Tue, Aug 8, 2023 at 10:55 AM Danny McCormick via dev wrote: > Hey everyone, I'd like to propose getting rid of OWNERS files from the > Beam repo. Right now, I don't think they are serving a meaningful

Re: [Discuss] Get rid of OWNERS files

2023-08-08 Thread XQ Hu via dev
+1. On Tue, Aug 8, 2023 at 10:55 AM Danny McCormick via dev wrote: > Hey everyone, I'd like to propose getting rid of OWNERS files from the > Beam repo. Right now, I don't think they are serving a meaningful purpose: > > - Many OWNERS files are outdated and point to people who are no longer > ac

[Discuss] Get rid of OWNERS files

2023-08-08 Thread Danny McCormick via dev
Hey everyone, I'd like to propose getting rid of OWNERS files from the Beam repo. Right now, I don't think they are serving a meaningful purpose: - Many OWNERS files are outdated and point to people who are no longer actively involved in the project (examples: 1