Re: Building dev docker image

2024-09-19 Thread Valentyn Tymofieiev via dev
On Thu, Sep 19, 2024 at 4:06 PM Robert Bradshaw via dev wrote: > > > On Thu, Sep 19, 2024 at 3:43 PM Joey Tran > wrote: > >> Ah okay then. I commented out the goavro line and the image does finish >> building. It seems that the python still has be built which takes a bit >> (using ` pip install

Re: Building dev docker image

2024-09-19 Thread Valentyn Tymofieiev via dev
or alternatively, commenting-out the cython dep in pyproject.toml might remove cythonization too. On Thu, Sep 19, 2024 at 4:16 PM Joey Tran wrote: > cython isn't installed in the virtualenv. Running `pip uninstall cython` > resulted in: > `WARNING: Skipping cython as it is not installed.` > > On

Re: Building dev docker image

2024-09-19 Thread Joey Tran
cython isn't installed in the virtualenv. Running `pip uninstall cython` resulted in: `WARNING: Skipping cython as it is not installed.` On Thu, Sep 19, 2024 at 7:05 PM Robert Bradshaw via dev wrote: > > > On Thu, Sep 19, 2024 at 3:43 PM Joey Tran > wrote: > >> Ah okay then. I commented out the

Re: Building dev docker image

2024-09-19 Thread Robert Bradshaw via dev
On Thu, Sep 19, 2024 at 3:43 PM Joey Tran wrote: > Ah okay then. I commented out the goavro line and the image does finish > building. It seems that the python still has be built which takes a bit > (using ` pip install -e .[gcp,test]` inside the sdks/python directory). It > looks like the source

Re: Building dev docker image

2024-09-19 Thread Joey Tran
Ah okay then. I commented out the goavro line and the image does finish building. It seems that the python still has be built which takes a bit (using ` pip install -e .[gcp,test]` inside the sdks/python directory). It looks like the source isn't synced with the host system it doesn't look like the

Re: Building dev docker image

2024-09-19 Thread Robert Burke
To my knowledge, the "dev" docker image is unmaintained, and has been for quite some time, hence not having been moved to Go Modules and similar. I personally don't have time to delve into what's going on with it, but IIRC, deleting the weird goavro lines would be a good first step. I'd be happy

Building dev docker image

2024-09-19 Thread Joey Tran
Hi, I'm trying again to get a working development image of beam. Working from the beam repo CONTRIBUTING.md, I ran `./start-build-env.sh` At image build time after getting a few steps in, the build fails with: => ERROR [7/8] RUN go get github.com/linkedin/goavro/v2 > [7/8] RUN go get github.co

Re: Supporting Dynamic Destinations in a portable context

2024-09-19 Thread Ahmed Abualsaud via dev
Hey everyone, During PR reviews, we saw that there are multiple valid alternatives for a dynamic destinations configuration with regards to naming and positioning. @Robert Bradshaw put together a doc [1] enumerating some of these options -- we hope to get some feedback on what looks best to you!

Beam High Priority Issue Report (49)

2024-09-19 Thread beamactions
This is your daily summary of Beam's current high priority issues that may need attention. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities. Unassigned P1 Issues: https://github.com/apache/beam/issues/31929 The PerformanceTest